----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23982/#review49217 -----------------------------------------------------------
test/integration/smoke/test_nic.py <https://reviews.apache.org/r/23982/#comment86104> Instead of taking this check to inside the test case code, please move it to setup, that way atleast it is good that test code is independent upon these checks? test/integration/smoke/test_nic.py <https://reviews.apache.org/r/23982/#comment86105> Another issue is does the test case does not hold for hyperv or test case code is not applicable? If test case code only, then a different addition for hyperv is required? - Santhosh Edukulla On July 28, 2014, 2:17 p.m., John Dilley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23982/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 2:17 p.m.) > > > Review request for cloudstack, sanjeev n and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7192 > https://issues.apache.org/jira/browse/CLOUDSTACK-7192 > > > Repository: cloudstack-git > > > Description > ------- > > A number of tests in the following files don't apply to Hyper-V. This patch > means they are skipped if an attempt is made to run them. > > test_nic.py > test_primary_storage.py > test_scale_vm.py > test_snapshots.py > test_vm_snapshots.py > test_volumes.py(test7 and test8 only) > > > Diffs > ----- > > test/integration/smoke/test_nic.py dd6de96 > test/integration/smoke/test_primary_storage.py 66aec59 > test/integration/smoke/test_scale_vm.py b5c89be > test/integration/smoke/test_snapshots.py 8b6fdd1 > test/integration/smoke/test_vm_snapshots.py 01626f5 > test/integration/smoke/test_volumes.py 6e9ea75 > > Diff: https://reviews.apache.org/r/23982/diff/ > > > Testing > ------- > > > Thanks, > > John Dilley > >
