----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24050/#review49193 -----------------------------------------------------------
Commit b919da8a5c54ec0f7d0c370203ccfb058cbe1a54 in cloudstack's branch refs/heads/master from Mike Tutkowski [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b919da8 ] CLOUDSTACK-7173 - ASF Subversion and Git Services On July 29, 2014, 12:56 p.m., Alex Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24050/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 12:56 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-7173 > https://issues.apache.org/jira/browse/CLOUDSTACK-7173 > > > Repository: cloudstack-git > > > Description > ------- > > The functions getNewMinIops and getNewMaxIops were returning long primitives, > this can throw a NPE as the underlying Long objects could be null, which was > causing volume resizes to fail. > > The only place this getter is called is expecting a Long object, so changing > it to return a Long rather than long should be safe. > > > Diffs > ----- > > server/src/com/cloud/storage/VmWorkResizeVolume.java 1caab10 > > Diff: https://reviews.apache.org/r/24050/diff/ > > > Testing > ------- > > Verified cloudstack still builds > > > Thanks, > > Alex Brett > >
