-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23856/
-----------------------------------------------------------

Review request for cloudstack, daan Hoogland, Murali Reddy, Hugo Trippaers, and 
SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
-------

The first test in the class is failing on asserting that distributed routing is 
enabled:

Traceback (most recent call last):
  File 
"/usr/local/Cellar/python/2.7.8/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
 line 329, in run
    testMethod()
  File 
"/Users/mferreira/development/workspace/cloudstack-sbp-vpc-tests/src/vpc-tests/all/test_vpc_distributed_routing_offering.py",
 line 292, in 
test_01_create_vpc_offering_with_distributedrouter_service_capability
    self.validate_vpc_offering(vpc_off)
  File 
"/Users/mferreira/development/workspace/cloudstack-sbp-vpc-tests/src/vpc-tests/all/test_vpc_distributed_routing_offering.py",
 line 245, in validate_vpc_offering
    "VPC offering is not set up for Distributed routing"
  File 
"/usr/local/Cellar/python/2.7.8/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
 line 513, in assertEqual
    assertion_func(first, second, msg=msg)
  File 
"/usr/local/Cellar/python/2.7.8/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
 line 506, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: VPC offering is not set up for Distributed routing
-------------------- >> begin captured stdout << ---------------------
=== TestName: 
test_01_create_vpc_offering_with_distributedrouter_service_capability | Status 
: FAILED ===


That is because it is using the global services configuration instead of the 
local one (where the distributed routing is enabled).
I've changed that and also added two new lines in between every python method 
to make the class more readable.

I did not manage to runt the other 2 tests in the class because my development 
setup does not support Ovs.


Diffs
-----

  test/integration/component/test_vpc_distributed_routing_offering.py cc9a191 

Diff: https://reviews.apache.org/r/23856/diff/


Testing
-------

The test that was failing now passes.


Thanks,

Miguel Ferreira

Reply via email to