----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23847/ -----------------------------------------------------------
(Updated July 23, 2014, 12:17 p.m.) Review request for cloudstack, daan Hoogland, Santhosh Edukulla, and Hugo Trippaers. Changes ------- Update diff to address remark (previous update sent the initial patch) Repository: cloudstack-git Description ------- Running a marvin test that does not specify a zone in the config file will produce an exception while parsing the config: Exception Occurred Under init ['Traceback (most recent call last):\n', ' File "/usr/local/lib/python2.7/site-packages/marvin/marvinInit.py", line 118, in __setHypervisorAndZoneInfo\n for zone in self.__parsedConfig.zones:\n', "TypeError: 'NoneType' object is not iterable\n"] This happens when the code starts iterating over a list of zones that does not exist. I've added a check for the existence of the list of zones before iterating. Diffs (updated) ----- tools/marvin/marvin/marvinInit.py ce9b43f Diff: https://reviews.apache.org/r/23847/diff/ Testing ------- Tests now run without the mentioned exception Thanks, Miguel Ferreira
