> On July 21, 2014, 2:12 p.m., Santhosh Edukulla wrote: > > tools/devcloud/devcloud-advanced.cfg, line 86 > > <https://reviews.apache.org/r/23737/diff/1/?file=636764#file636764line86> > > > > whats the significance of this change?
As I said in the description, I reordered some parameters to increase readability. for instance having startip before endip, I think, increases readability. > On July 21, 2014, 2:12 p.m., Santhosh Edukulla wrote: > > tools/devcloud/devcloud-advanced.cfg, line 126 > > <https://reviews.apache.org/r/23737/diff/1/?file=636764#file636764line126> > > > > Instead of these elements, please use advanced.cfg for reference and > > use logger element in similar, now marvin and test cases as such do not > > worry about testclient.log or testcase.log. Instead, logging was simplified > > to dump failed exception logs, run log and result log for each test suite, > > these elements can be removed, but log path can still be used. I did not introduce that. The elements were already there. - Miguel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23737/#review48219 ----------------------------------------------------------- On July 21, 2014, 1:42 p.m., Miguel Ferreira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23737/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 1:42 p.m.) > > > Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Wei Zhou. > > > Repository: cloudstack-git > > > Description > ------- > > Added step-wise log messages during deploy data center. > > Also reordered some parameters in the advanced zone config for better > readability. > > > Diffs > ----- > > tools/devcloud/devcloud-advanced.cfg 74b6366 > tools/marvin/marvin/deployDataCenter.py ae48839 > > Diff: https://reviews.apache.org/r/23737/diff/ > > > Testing > ------- > > Used deployDataCenter.py together with advanced zone config to deploy a zone > in my development environment > > > Thanks, > > Miguel Ferreira > >
