-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22693/#review47863
-----------------------------------------------------------
Patch failed to apply on master, please check.
chandan2.patch:37: trailing whitespace.
chandan2.patch:57: trailing whitespace.
return PhysicalNetwork(apiclient.createPhysicalNetwork(cmd).__dict__)
chandan2.patch:92: trailing whitespace.
chandan2.patch:99: trailing whitespace.
return(apiclient.configureVirtualRouterElement(cmd))
chandan2.patch:100: trailing whitespace.
warning: tools/marvin/marvin/lib/base.py has type 100755, expected 100644
error: patch failed: tools/marvin/marvin/lib/base.py:1909
error: tools/marvin/marvin/lib/base.py: patch does not apply
- Santhosh Edukulla
On June 17, 2014, 7:25 p.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22693/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 7:25 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha
> hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and
> SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Currently methods in DiskOffering, StoragePool and Physical Network restrict
> the programmer to use limited parameters. I made changes to the methods in
> those classes to accept more parameters that can be used during test script
> programming.
>
> Added VirtualRouterElements, InternalLoadBalancerElements classes to base.py
> . The code will make the test script programming easier for programmers
> writing test scripts related to Zones.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/lib/base.py 8b89087
>
> Diff: https://reviews.apache.org/r/22693/diff/
>
>
> Testing
> -------
>
> Test Suite was scripted and tested with the above mentioned additions to
> base.py.
>
>
> Thanks,
>
> Chandan Purushothama
>
>
