Sure, that makes sense - thanks. It's too bad we don't really have a standard for our API in terms of how volume sizes are referenced. It seems sometimes we use bytes while other times we use GB. I was thinking the units were bytes here, but they are GB.
On Fri, Jul 11, 2014 at 3:55 PM, Nitin Mehta <nitin.me...@citrix.com> wrote: > Probably converting from GB to bytes ? I recall doing that for creating > volumes from custom disk offering. > > On 11/07/14 2:07 PM, "Mike Tutkowski" <mike.tutkow...@solidfire.com> > wrote: > > >Hi, > > > >In the resize-volume command, I see this logic: > > > > if (diskOffering.isCustomized() || > >volume.getVolumeType().equals(Volume.Type.ROOT)) { > > > > newSize = cmd.getSize(); > > > > > > if (newSize != null) { > > > > newSize = (newSize << 30); > > > > } > > > > } > > > >Any thoughts on why we are shifting bits 30 places to the left? > > > >I don't recall us doing this in other places for long values? > > > >This is in VolumeApiServiceImpl.resizeVolume. > > > >Thanks! > >-- > >*Mike Tutkowski* > >*Senior CloudStack Developer, SolidFire Inc.* > >e: mike.tutkow...@solidfire.com > >o: 303.746.7302 > >Advancing the way the world uses the cloud > ><http://solidfire.com/solution/overview/?video=play>* * > > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud <http://solidfire.com/solution/overview/?video=play>*™*