> On July 1, 2014, 3 p.m., Santhosh Edukulla wrote: > > tools/marvin/marvin/configGenerator.py, line 91 > > <https://reviews.apache.org/r/23169/diff/1/?file=620478#file620478line91> > > > > Does cfg, files used has these option of domain? > > > > As well, please test it on both 4.4-forward and master, if it need to > > go to both? > > John Dilley wrote: > > Does cfg, files used has these option of domain? > > Hi Santhosh, > > Not quite sure what you mean here - can you clarify? > > Thanks, > > John > > Santhosh Edukulla wrote: > I mean, does cfg file say advanced.cfg requires this flag, as well, what > if zone.domain is None, does createZone command leads to any issue? > > John Dilley wrote: > No problem if zone.domain is not specified - createZone will behave as > before, not specifying a domain (and will default to cs<n>.internal) > > Santhosh Edukulla wrote: > Ok, can you please mention the bugid, and related branches information > for this review submission?
Added above. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23169/#review47065 ----------------------------------------------------------- On July 8, 2014, 9:48 a.m., John Dilley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23169/ > ----------------------------------------------------------- > > (Updated July 8, 2014, 9:48 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7010 > https://issues.apache.org/jira/browse/CLOUDSTACK-7010 > > > Repository: cloudstack-git > > > Description > ------- > > Add domain to createZones in deployDataCenter > > > Diffs > ----- > > tools/marvin/marvin/configGenerator.py 8daaaa9 > tools/marvin/marvin/deployDataCenter.py c097238 > > Diff: https://reviews.apache.org/r/23169/diff/ > > > Testing > ------- > > Tested deployDataCenter, both with and without specifying a domain > > > Thanks, > > John Dilley > >
