----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22721/#review47297 -----------------------------------------------------------
Ship it! Applied to 4.3 branch for 4.3.1 release thanks, you can mark the review as submitted - Sebastien Goasguen On July 3, 2014, 8:59 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22721/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 8:59 a.m.) > > > Review request for cloudstack, Kishan Kavala, Rayees Namathponnan, and > Sebastien Goasguen. > > > Bugs: CLOUDSTACK-6926 > https://issues.apache.org/jira/browse/CLOUDSTACK-6926 > > > Repository: cloudstack-git > > > Description > ------- > > used to readlink -e and dirname to get the JAVA_HOME > if JAVA_HOME is not already defined, sets it to jdk home if javac is present > else jre home if java is present. > if nothing is present, it exits with error > > > Diffs > ----- > > packaging/centos63/cloud-usage.rc e78f8c1 > packaging/debian/init/cloud-usage 1cc75cc > > Diff: https://reviews.apache.org/r/22721/diff/ > > > Testing > ------- > > > tested it when java is not installed, jre is installed, jdk installed or when > a older version is installed on centos 6.4 and ubuntu 14.04 > > > Thanks, > > Rajani Karuturi > >
