> On July 1, 2014, 10:36 a.m., Koushik Das wrote: > > Why are tests using simulator mock moved to 'maint' folder? > > > > If you remove test_deploy_vm.py make sure that the following test is moved > > to another file. This is meant to test list VM with multiple 'ids'. > > > > @attr(tags = ['advanced', 'basic', 'sg'], required_hardware="false") > > def test_deploy_vm_multiple(self): > > > > > > Gaurav Aradhye wrote: > Sure, I will move that test case to different suite. > > The test cases using SimulatorMock fail when run along with other test > suites in parallel. Also, due to them other test cases fail, e.g. the test > case which simulate host failure. Hence these need to be moved to separate > folder, so that these test cases can be run serially. > > Are you suggesting a different folder name other than maint? > > Koushik Das wrote: > As long as the the simulator tests gets executed no issues. The name of > the folder is misleading, if the purpose is to put all tests that needs > serial execution then name it appropriately. > > Gaurav Aradhye wrote: > I have moved test to test_vm_life_cycle.py as it already had test related > to deploy and list the VM. > Also renamed it to "test_list_vms_multiple_ids". > > Renamed to maint to SimulatorMockTests > > Please review the updated patch.
I am ok with the changes. - Koushik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23195/#review47049 ----------------------------------------------------------- On July 2, 2014, 6:55 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23195/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 6:55 a.m.) > > > Review request for cloudstack, Koushik Das and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6873 > https://issues.apache.org/jira/browse/CLOUDSTACK-6873 > > > Repository: cloudstack-git > > > Description > ------- > > Moving tests using SimulatorMock into maint folder. Also removed duplicate > test cases from test_deploy_vm.py. These tests are already covered in > test_vm_life_cycle.py > > > Diffs > ----- > > test/integration/smoke/misc/__init__.py PRE-CREATION > test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION > test/integration/smoke/misc/test_vm_ha.py PRE-CREATION > test/integration/smoke/test_deploy_vm.py ed5dfaf > test/integration/smoke/test_vm_ha.py 1d9021c > test/integration/smoke/test_vm_life_cycle.py 240ab68 > > Diff: https://reviews.apache.org/r/23195/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
