Hi Daan,

The first part is to check if user is not passing "type" field to query only 
one resource type so that in result, we'll have more than one elements; and the 
second part of the check fetching the zoneId, podId and clusterId from the 
existing result to get the GPU resource capacity details.

And, thanks for pushing the patch :) .

--Sanjay 

-----Original Message-----
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Friday, June 27, 2014 1:15 PM
To: Sanjay Tripathi
Cc: dev@cloudstack.apache.org
Subject: Re: [ACS4.4] cherry pick commit 
dc22566c642e400014332045a224e5545d33a11c and 
48646ae186eb75052da3da385404a823bd785444

One question Sanjay,

The second commit changes a check of .isEmpty() to .size() >1 and then does 
some checks on element 0. So what is the significance of this. It is not 
intuitive what happens here. Can you explain?

I gave it the benefit of the doubt and cherry-picked both, btw.

On Fri, Jun 27, 2014 at 8:28 AM, Sanjay Tripathi <sanjay.tripa...@citrix.com> 
wrote:
> Hi Daan,
>
> Could you please cherry-pick following commits to 4.4 branch.
>
> Commit: dc22566c642e400014332045a224e5545d33a11c
> CLOUDSTACK-6453: [GPU] Windows 2012 Server instance created with vGPU 
> offering is not coming up after installing PV drivers.
>
> Commit: 48646ae186eb75052da3da385404a823bd785444
> CLOUDSTACK-6884: List Capacity API always returns GPU capacity also even if 
> type is different.
>
>
> --Sanjay



--
Daan

Reply via email to