----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/#review46719 -----------------------------------------------------------
Alex, As discussed on the mailing list, ORIGINATEDREGIONUUID should be the regionId which is Long. So all the ORIGINATEDREGIONUUID references should just be ORIGINATEDREGIONID and of datatype Long. - Kishan Kavala On June 24, 2014, 9:24 p.m., Alex Ough wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20099/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 9:24 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > This is the review request for the core changes related with #17790 that has > only the new plugin codes. > > > Diffs > ----- > > api/src/com/cloud/event/EventTypes.java 0fa3cd5 > api/src/com/cloud/user/AccountService.java eac8a76 > api/src/com/cloud/user/DomainService.java 4c1f93d > api/src/org/apache/cloudstack/api/ApiConstants.java adda5f4 > api/src/org/apache/cloudstack/api/BaseCmd.java ac9a208 > > api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java > 50d67d9 > > api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java > 5754ec5 > > api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java > 3e5e1d3 > > api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java > f30c985 > api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java > 3c185e4 > > api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java > a7ce74a > api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java > 312c9ee > api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java > a6d2b0b > api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java > 409a84d > api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java > f6743ba > api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java > b08cbbb > api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java > 8f223ac > api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java > 08ba521 > api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java > c6e09ef > api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java > d69eccf > api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java > 69623d0 > api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java > 2090d21 > api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java > f21e264 > api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 > api/src/org/apache/cloudstack/region/Region.java df64e44 > api/src/org/apache/cloudstack/region/RegionService.java afefcc7 > api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 > client/pom.xml 29fef4f > > engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml > 2ef0d20 > engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 > engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b > > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java > 4136b5c > plugins/pom.xml b5e6a61 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java > b753952 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java > 6f7be90 > server/src/com/cloud/api/ApiResponseHelper.java f1f0d2c > server/src/com/cloud/api/dispatch/ParamProcessWorker.java 1592b93 > server/src/com/cloud/event/ActionEventUtils.java 2b3cfea > server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 > server/src/com/cloud/user/AccountManager.java 194c5d2 > server/src/com/cloud/user/AccountManagerImpl.java 7a889f1 > server/src/com/cloud/user/DomainManager.java f72b18a > server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 > server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 > server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 > server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 > server/test/com/cloud/user/AccountManagerImplTest.java 176cf1d > server/test/com/cloud/user/MockAccountManagerImpl.java 746fa1b > server/test/com/cloud/user/MockDomainManagerImpl.java 7dddefb > server/test/org/apache/cloudstack/region/RegionManagerTest.java d7bc537 > setup/db/db/schema-440to450.sql ee419a2 > ui/scripts/regions.js 368c1bf > > Diff: https://reviews.apache.org/r/20099/diff/ > > > Testing > ------- > > 1. Successfully tested real time synchronization as soon as resources are > created/deleted/modified in one region. > 2. Successfully tested full scans to synchronize resources that were missed > during real time synchronization because of any reasons like network > connection issues. > 3. The tests were done manually and also automatically by randomly generating > changes each region. > > > Thanks, > > Alex Ough > >
