----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22830/#review46361 -----------------------------------------------------------
Ship it! 1c80185170235eca6ac26c72b4145b1b46313ed1 - daan Hoogland On June 20, 2014, 7:23 p.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22830/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 7:23 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and daan Hoogland. > > > Bugs: coverity > https://issues.apache.org/jira/browse/coverity > > > Repository: cloudstack-git > > > Description > ------- > > Fixed resource leaks,invalid value comparisons,null dereferences, invalid > result set loop comparison. > All these issues were fixed in master branch > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/DatabaseCreator.java 91ef318 > engine/schema/src/com/cloud/upgrade/DatabaseIntegrityChecker.java c20a418 > engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java f508df2 > framework/db/src/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java > 58584f9 > framework/db/src/com/cloud/utils/db/Merovingian2.java 89f9e61 > framework/db/src/com/cloud/utils/db/ScriptRunner.java 6614527 > framework/db/src/com/cloud/utils/db/TransactionLegacy.java f50cbe2 > server/src/com/cloud/test/IPRangeConfig.java 1d56471 > usage/src/com/cloud/usage/UsageSanityChecker.java 50f6fe5 > utils/src/com/cloud/utils/crypt/EncryptionSecretKeySender.java 086e8a8 > > Diff: https://reviews.apache.org/r/22830/diff/ > > > Testing > ------- > > Built the code post the changes, ran a deploy data center. > > > Thanks, > > Santhosh Edukulla > >
