----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22356/ -----------------------------------------------------------
(Updated June 11, 2014, 6:43 a.m.) Review request for cloudstack and daan Hoogland. Changes ------- Fixed mentioned issues Repository: cloudstack-git Description ------- Fixed few coverity issues reported for resource leak, value comparison, invalid loop check for result set. Diffs (updated) ----- engine/schema/src/com/cloud/upgrade/DatabaseCreator.java 91ef318 engine/schema/src/com/cloud/upgrade/DatabaseIntegrityChecker.java c20a418 engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 0761c9f framework/db/src/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java 58584f9 framework/db/src/com/cloud/utils/db/Merovingian2.java 6eeea9f framework/db/src/com/cloud/utils/db/ScriptRunner.java 6614527 framework/db/src/com/cloud/utils/db/TransactionLegacy.java ac0ea21 server/src/com/cloud/test/IPRangeConfig.java 1d56471 usage/src/com/cloud/usage/UsageSanityChecker.java 5e6123b utils/src/com/cloud/utils/crypt/EncryptionSecretKeySender.java 086e8a8 Diff: https://reviews.apache.org/r/22356/diff/ Testing ------- 1.Built the code and found no issues. 2.Built the simulator and ran a deploy datacenter with the changes. Thanks, Santhosh Edukulla
