I believe it to be valid still. I'll review later and confirm. I know you had 
comments on the patch which I had addressed.




> On 10 Jun 2014, at 15:50, "daan Hoogland" <daan.hoogl...@gmail.com> wrote:
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19616/#review45234
> -----------------------------------------------------------
> 
> 
> is this still a valid patch? should it be deleted?
> 
> - daan Hoogland
> 
> 
>> On April 15, 2014, 10:18 a.m., Alex Hitchins wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/19616/
>> -----------------------------------------------------------
>> 
>> (Updated April 15, 2014, 10:18 a.m.)
>> 
>> 
>> Review request for cloudstack and daan Hoogland.
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> -------
>> 
>> Added check for returned null, if received then throw exception.
>> 
>> Amendments made as per dev mailing list comments.
>> 
>> 
>> Diffs
>> -----
>> 
>>  server/src/com/cloud/storage/VolumeApiServiceImpl.java 680cd2e 
>> 
>> Diff: https://reviews.apache.org/r/19616/diff/
>> 
>> 
>> Testing
>> -------
>> 
>> Compiled & ran.
>> 
>> 
>> Thanks,
>> 
>> Alex Hitchins
> 

Reply via email to