----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19874/#review44890 -----------------------------------------------------------
Commit 6c0b43431f7f117c1fcb049c483407b96b56d961 in cloudstack's branch refs/heads/4.4 from sedukull [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6c0b434 ] CLOUDSTACK-6793: Fixed an invalid Domain Id Issue Signed-off-by: sedukull <santhosh.eduku...@gmail.com> (cherry picked from commit 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc) - ASF Subversion and Git Services On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19874/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 9:28 a.m.) > > > Review request for cloudstack, daan Hoogland and Kishan Kavala. > > > Bugs: CLOUDSTACK-6793 > https://issues.apache.org/jira/browse/CLOUDSTACK-6793 > > > Repository: cloudstack-git > > > Description > ------- > > 1. Added fix to retrieve the correct domain id for a given accountid. > vm_template table and respective vo, does not have a domain id information. > 2. Added logic to retrieve correct domainid for a given accountid, only when > an invalid domainid is retrieved. Throw an exception in case of invalid > domain id. > 3. Now, creation of tags is getting successful post the fix. > > > Diffs > ----- > > engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd > engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed > server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7 > > Diff: https://reviews.apache.org/r/19874/diff/ > > > Testing > ------- > > Test creation, listing and deletion tags on UserVM ... === TestName: > test_05_vm_tag | Status : SUCCESS === > ok > Test creation, listing and deletion tag on templates ... === TestName: > test_06_template_tag | Status : SUCCESS === > ok > Test creation, listing and deletion tags on ISO ... === TestName: > test_07_iso_tag | Status : SUCCESS === > ok > Test creation, listing and deletion tagson volume ... === TestName: > test_08_volume_tag | Status : SUCCESS === > ok > > > Thanks, > > Santhosh Edukulla > >
