The defect density came down to 3.92 from around 6.5 :) Thanks for fixing the pattern Animesh.
~Rajani On 05-Jun-2014, at 11:58 am, Hugo Trippaers <h...@trippaers.nl> wrote: > Heya, > > Thanks for helping out with the coverity configuration. > > The coverity builds are run automagically from Jenkins every monday and > friday. Based on our project size we can submit a maximum of two builds per > week. The choices for monday and friday are arbitraty so if other days suit > our workflow better any Jenkins admin can adapt the configuration. > > > Cheers, > > Hugo > > On 5 jun. 2014, at 02:01, Animesh Chaturvedi <animesh.chaturv...@citrix.com> > wrote: > >> >> While we should wait for the next run for actual results but I am expecting >> the defect density as reported by Coverity to drop down from 6.4 to about >> 3.4 after excluding AWSAPI generated code. >> >> Animesh >> >>> -----Original Message----- >>> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] >>> Sent: Wednesday, June 04, 2014 3:56 PM >>> To: dev@cloudstack.apache.org >>> Subject: RE: New Defects reported by Coverity Scan for cloudstack >>> >>> Rajani >>> >>> Thanks for bringing this up, I looked at the analysis settings and I think >>> the >>> pattern to exclude aws code should have a leading /. I have fixed it and >>> lets >>> check it on the next run. We should see a significant bump up in defect >>> density. >>> Good job in noticing this. >>> >>> Thanks >>> Animesh >>> >>>> -----Original Message----- >>>> From: Rajani Karuturi [mailto:rajani.karut...@citrix.com] >>>> Sent: Monday, June 02, 2014 11:48 PM >>>> To: dev >>>> Subject: Re: New Defects reported by Coverity Scan for cloudstack >>>> >>>> These are the approximate number of defects reported by coverity from >>>> the generated code. >>>> >>>>> /awsapi/src/com/amazon/ec2 -> around 4300 >>>> >>>>> /awsapi/src/com/amazon/s3 -> around 350 >>>> >>>> >>>> total defects -> around 6500 >>>> >>>> ~Rajani >>>> >>>> >>>> >>>> On 02-Jun-2014, at 4:57 pm, Rajani Karuturi <rajani.karut...@citrix.com> >>> wrote: >>>> >>>>> Hi Hugo, >>>>> >>>>> awsapi-generated-code is excluded for the project but I still see >>>>> issues >>>> reported in them. >>>>> For example for file src/com/amazon/ec2/DeleteTagsResponseType.java >>>>> >>>>> >>>>> Can you check the file exclude pattern? I think .* is missing >>>>> (awsapi/src/com/amazon/.*) >>>>> >>>>> Fixing this might give us a better report as I see lot of them listed in >>>>> these >>> files. >>>>> >>>>> >>>>> ~Rajani >>>>> >>>>> >>>>> >>>>> On 29-Nov-2013, at 9:28 pm, Hugo Trippaers <trip...@gmail.com> wrote: >>>>> >>>>>> FYI >>>>>> >>>>>> Sent from my iPhone >>>>>> >>>>>> Begin forwarded message: >>>>>> >>>>>>> From: scan-ad...@coverity.com >>>>>>> Date: 29 november 2013 14:39:56 CET >>>>>>> Subject: New Defects reported by Coverity Scan for cloudstack >>>>>>> >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> >>>>>>> Please find the latest report on new defect(s) introduced to >>>>>>> cloudstack >>>> found with Coverity Scan. >>>>>>> >>>>>>> Defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) >>>>>>> >>>>>>> >>>>>>> ** CID 1116269: Nesting level does not match indentation >>>>>>> (NESTING_INDENT_MISMATCH) >>>>>>> /awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider >>>>>>> .j >>>>>>> ava: 124 in >>>>>>> com.cloud.bridge.service.controller.s3.ServiceProvider.getManageme >>>>>>> nt >>>>>>> HostId()() >>>>>>> >>>>>>> ** CID 1133706: Dereference after null check (FORWARD_NULL) >>>>>>> /server/src/com/cloud/vm/UserVmManagerImpl.java: 2803 in >>>>>>> >>> com.cloud.vm.UserVmManagerImpl$3.doInTransaction(com.cloud.utils.db. >>>>>>> TransactionStatus)() >>>>>>> >>>>>>> ** CID 1133705: Resource leak on an exceptional path >>>>>>> (RESOURCE_LEAK) >>>>>>> /server/src/com/cloud/server/ConfigurationServerImpl.java: 638 in >>>>>>> com.cloud.server.ConfigurationServerImpl.updateSSLKeystore()() >>>>>>> >>>>>>> ** CID 1133704: SS: Unread field should be static >>>>>>> (FB.SS_SHOULD_BE_STATIC) >>>>>>> /server/src/com/cloud/uuididentity/UUIDManagerImpl.java: 43 in () >>>>>>> >>>>>>> ** CID 1133703: Dm: Dubious method used >>> (FB.DM_DEFAULT_ENCODING) >>>>>>> /plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/co >>>>>>> mm >>>>>>> and/LdapImportUsersCmd.java: 197 in >>>>>>> >>>> org.apache.cloudstack.api.command.LdapImportUsersCmd.generatePasswor >>>>>>> d()() >>>>>>> >>>>>>> ** CID 1133702: DLS: Dead local store (FB.DLS_DEAD_LOCAL_STORE) >>>>>>> /plugins/network-elements/juniper-contrail/src/org/apache/cloudsta >>>>>>> ck >>>>>>> /network/contrail/model/VirtualMachineModel.java: 119 in >>>>>>> org.apache.cloudstack.network.contrail.model.VirtualMachineModel.b >>>>>>> ui >>>>>>> ldServiceInstance(org.apache.cloudstack.network.contrail.model.Mod >>>>>>> el >>>>>>> Controller, java.lang.String)() >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>> >>> _________________________________________________________________ >>>> ___ >>>>>>> ____________________________________ >>>>>>> To view the defects in Coverity Scan visit, >>>>>>> http://scan.coverity.com >>>>>>> >>>>>>> To unsubscribe from the email notification for new defects, >>>>>>> http://scan5.coverity.com/cgi-bin/unsubscribe.py >>>>>>> >>>>>>> >>>>>>> >>>>> >> >
