> On June 3, 2014, 11:22 a.m., Santhosh Edukulla wrote: > > test/integration/smoke/test_non_contigiousvlan.py, line 29 > > <https://reviews.apache.org/r/22197/diff/1/?file=602789#file602789line29> > > > > Is it ok to move to test data?
Removed services dictionary as it is no longer used - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44612 ----------------------------------------------------------- On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22197/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 11:45 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6776 > https://issues.apache.org/jira/browse/CLOUDSTACK-6776 > > > Repository: cloudstack-git > > > Description > ------- > > The test case fails whenever hard coded values overlap with already > configured VLAN in the physical network. Removed hard code VLAN ids and used > the common function to get unused VLAN ids from the physical network > dynamically. > > > Diffs > ----- > > test/integration/smoke/test_non_contigiousvlan.py 90235ec > > Diff: https://reviews.apache.org/r/22197/diff/ > > > Testing > ------- > > Yes. > > Log: > Test to update a physical network and extend its vlan ... === TestName: > test_extendPhysicalNetworkVlan | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 1 test in 15.328s > > OK > ~ > ~ > > > Thanks, > > Ashutosh Kelkar > >
