----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22193/ -----------------------------------------------------------
(Updated June 3, 2014, 8:41 a.m.) Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Changes ------- uploaded another patch to fix the issue raised by Santhosh in the review comment "Not able to mark it inside the review, so making a note here. The below statement ( preparestatement creation) is called inside the while loop multiple times, but was closed only once in finally. This may still result in leak. pstmtCidr = conn.prepareStatement(networkAclItemCidrSql); 1. Either use the existing logic only, but move pstmtCidr.close(); inside the inner for loop. 2. Or a way to create prpearestatement out of while loop and execute multiple sql statements, provided preparestatement creation is successful and execute them in batch. " Repository: cloudstack-git Description ------- The issue is reported by coverity scan @ https://scan.coverity.com/projects/943 Diffs (updated) ----- engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java 7fe285f Diff: https://reviews.apache.org/r/22193/diff/ Testing ------- Thanks, Rajani Karuturi
