-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21912/
-----------------------------------------------------------

Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-6764
    https://issues.apache.org/jira/browse/CLOUDSTACK-6764


Repository: cloudstack-git


Description
-------

When network id is passed while deploying VM in advanced zone, it is not passed 
to method "access_ssh_over_nat", hence associating public ip address fails with 
"more than one network exists in account". Network id must be passed to 
"PublicIPAddress.create" method in this case.


Diffs
-----

  tools/marvin/marvin/lib/base.py c975c37 

Diff: https://reviews.apache.org/r/21912/diff/


Testing
-------

Yes. Tested both  - test cases which pass network id while deploying VM, and 
those which do not pass.


test_add_remove_networks test cases result: (Tests above scenario perfectly)
Add network to running VM ... SKIP: skip
Add network to stopped VM ... === TestName: 
test_02_add_nw_stopped_vm_1_isolated | Status : SUCCESS ===
ok
Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_2_shared 
| Status : SUCCESS ===
ok
Add same network multiple times to running VM ... === TestName: 
test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS ===
ok
Add same network multiple times to running VM ... === TestName: 
test_03_add_nw_multiple_times_2_shared | Status : SUCCESS ===
ok
Add VPC network to running VM belonging to isolated network ... === TestName: 
test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS ===
ok
Add network and ip address to running VM ... === TestName: 
test_06_add_nw_ipaddress_running_vm | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 7 tests in 902.523s

OK (SKIP=1)


BVT test suite - test_vm_life_cycle: (Does not pass network id)
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS 
===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : 
SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : 
SUCCESS ===
ok
Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
ok
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | 
Status : SUCCESS ===
ok
Test for attach and detach ISO to virtual machine ... === TestName: 
test_10_attachAndDetach_iso | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 8 tests in 778.989s

OK


Thanks,

Gaurav Aradhye

Reply via email to