> On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote: > > test/integration/component/test_escalations_networks.py, lines 434-435 > > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line434> > > > > May be get the count as it is for before vpc list, need not be zero? > > Especially if multiple tests run in parallel, there could be a possibility > > we may get the count varying.
Here we are checking for Zero VPCs in that account and also kept asserts as such. This we have followed for all the automated tests. So we shall leave it as such for now > On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote: > > test/integration/component/test_escalations_networks.py, line 640 > > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line640> > > > > Move this to above line after vpc creation. Here we are creating VPC and then Network under VPC, so first we need to clean Network and then only VPC, if we are adding cleaning of VPC first and network later then during cleanup it was giving error saying "network exists in the vpc" > On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote: > > test/integration/component/test_escalations_networks.py, line 949 > > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line949> > > > > Not clear with this check. Why cant we just append to cleanup? We wanted this check as we need not add all the VM's created as we are deleting one VM in test itself. > On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote: > > test/integration/component/test_escalations_networks.py, line 1108 > > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line1108> > > > > Can this be moved after create? Here we are creating VPC and then Network under VPC, so first we need to clean Network and then only VPC, if we are adding cleaning of VPC first and network later then during cleanup it was giving error saying "network exists in the vpc" > On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote: > > test/integration/component/test_escalations_networks.py, line 2091 > > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line2091> > > > > Do we require some time to check whether vpc started or failed? We donot need any time, since it is async call framework is handling > On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote: > > test/integration/component/test_escalations_networks.py, line 2471 > > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line2471> > > > > For delete we require some time to wait? We donot need any time, since it is async call framework is handling - Vinay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21628/#review43594 ----------------------------------------------------------- On May 19, 2014, 11:36 a.m., Monis Majeed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21628/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 11:36 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6282 > https://issues.apache.org/jira/browse/CLOUDSTACK-6282 > > > Repository: cloudstack-git > > > Description > ------- > > Automated network API Tests and uploaded patch > > > Diffs > ----- > > test/integration/component/test_escalations_networks.py PRE-CREATION > tools/marvin/marvin/config/test_data.py 5577ae1 > tools/marvin/marvin/lib/base.py 0a6405d > > Diff: https://reviews.apache.org/r/21628/diff/ > > > Testing > ------- > > Executed all the Network tests and uploaded the results file > > > File Attachments > ---------------- > > results.txt > > https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt > > > Thanks, > > Monis Majeed > >
