----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21380/#review43344 -----------------------------------------------------------
Ship it! Ship It! - Santhosh Edukulla On May 19, 2014, 8:20 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21380/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 8:20 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6618 > https://issues.apache.org/jira/browse/CLOUDSTACK-6618 > > > Repository: cloudstack-git > > > Description > ------- > > Fixing issues in SSHClient and config. > > 1) Public port for natrule was 2222, it should be 22. > 2) Indetation of "return" statement was wrong (Look at line no. 157), due to > which it was returning in first attempt itself without going for maximum no. > of retry counts. > 3) Removed unused imports > > > Diffs > ----- > > tools/marvin/marvin/config/test_data.py 026f5ff > tools/marvin/marvin/sshClient.py 76f3b6d > > Diff: https://reviews.apache.org/r/21380/diff/ > > > Testing > ------- > > Yes. > > > Test for port forwarding on source NAT ... === TestName: > test_01_port_fwd_on_src_nat | Status : SUCCESS === > ok > Test for port forwarding on non source NAT ... SKIP: skip > > ---------------------------------------------------------------------- > Ran 2 tests in 1922.008s > > OK (SKIP=1) > > > Thanks, > > Gaurav Aradhye > >
