Yes, that is a good point. We can fix test cases to revoke grant at tear down of each test case.
Thanks -min On 5/12/14 9:21 PM, "Rajani Karuturi" <rajani.karut...@citrix.com> wrote: >Assuming the order in which test cases should run is not a good practice. >Every test case should do the setup required for it and also the teardown >once its done so that it leaves the system clean in the same state it >started with. >This also helps in easy understanding of what is being tested. >I think we should file a bug for this and fix it. > >~Rajani > > > >On 12-May-2014, at 10:16 pm, Min Chen ><min.c...@citrix.com<mailto:min.c...@citrix.com>> wrote: > >Hi Sonal, > >That is because test_03_grant_account_vm is running after >test_02_grant_domain_vm, where we have granted domain2 VM to account_1B. >At the end of test_02_grant_domain_vm, we didn't revoke this granting, so >it will still take effect in test_03_grant_account_vm. Therefore, in >test_03, account_1B should have two grants effective, and thus he can see >3 VMs. > >Thanks >-min > >From: Sonal Ojha ><sonal.o...@sungardas.com<mailto:sonal.o...@sungardas.com>> >Date: Monday, May 12, 2014 5:04 AM >To: Prachi Damle ><prachi.da...@citrix.com<mailto:prachi.da...@citrix.com>>, Min Chen ><min.c...@citrix.com<mailto:min.c...@citrix.com>> >Cc: "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" ><dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>> >Subject: [QUERY] [IAM TEST CASE] Vritual Machine IAM test scenarios > >Hello, > >I have a small query regarding the sample test case written for virtual >machine entity type for the IAM plugin. > >The test case test_03_grant_account_vm which is to validate the below >mentioned scenarios is returning vms for all the three accounts >(account_1A, account_1B and account_2A) as the list_vm_response. > ># Validate the following > # 1. Grant account_1A VM access to account_1B > # 2. listVM command should return account_1A and account_1B VMs. > >Shouldn't it be returning vms for the two accounts (account_1A and >account_1B)? Kindly help to understand this scenario. > >-- >Thanks and Regards, >Sonal Ojha ▪ Sr.Engineer - Product Development ▪ Sungard Availability >Services, India >2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 >▪ Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ >sonal.o...@sungardas.com<mailto:sonal.o...@sungardas.com> ▪ >www.sungardas.<http://www.sungardas.com/>in ><http://www.sungardas.com/> ><http://blog.sungardas.com/> <http://www.youtube.com/user/SunGardAS> ><https://plus.google.com/u/0/102459878242108588663/posts> ><https://www.facebook.com/SunGardAS> ><http://www.linkedin.com/company/sungard-availability-services> ><https://twitter.com/SunGardAS> >CONFIDENTIALITY: This e-mail (including any attachments) may contain >confidential, proprietary and privileged information, and unauthorized >disclosure or use is prohibited. If you received this e-mail in error, >please notify the sender and delete this e-mail from your system. >
