----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21088/#review42274 -----------------------------------------------------------
Ship it! thanks for the patch, you can close the review as submitted - Sebastien Goasguen On May 5, 2014, 9:44 p.m., Sam Schmit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21088/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 9:44 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-6472 > https://issues.apache.org/jira/browse/CLOUDSTACK-6472 > > > Repository: cloudstack-git > > > Description > ------- > > Running "listUsageRecords" when there were any destroyed/expunged Virtual > Machines would return errors (on 4.3) or return null UUIDs (on master). The > UUID is important for correlating records. > > > Diffs > ----- > > server/src/com/cloud/api/ApiResponseHelper.java a8bef47 > utils/src/com/cloud/utils/db/EntityManager.java d613d7d > > Diff: https://reviews.apache.org/r/21088/diff/ > > > Testing > ------- > > 1) Created virtual machine > 2) Ran usage > 3) ran "listUsageRecords" API call, successful data returned > 4) Expunged VM > 5) Ran usage > 6) ran "listUsageRecords" API call, successful data returned (this would > previously return an error) > > > Thanks, > > Sam Schmit > >
