----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19758/#review42255 -----------------------------------------------------------
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java <https://reviews.apache.org/r/19758/#comment76046> As this is a new file content. please run rat build to verify the license plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java <https://reviews.apache.org/r/19758/#comment76050> Are there any UnitTests available to test this element? any marvin tests are available? plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java <https://reviews.apache.org/r/19758/#comment76047> systemvm service offering can be used or seed required offering and use it. plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java <https://reviews.apache.org/r/19758/#comment76048> how this template will be seeded? user will upload this template? plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java <https://reviews.apache.org/r/19758/#comment76049> what if there are multiple "Juniper vSRX" templates are available? findBytemplateName method will not search on "uniquename" it will search on template name and template name can be same for other templates also. this should be documented that uploaded template name should be with "Juniper vSRx" otherwise even user uploads it, code wont be able to find it. which hypervisor template is supported? plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java <https://reviews.apache.org/r/19758/#comment76051> missed formatting - Rajesh Battala On May 3, 2014, 7:30 a.m., Sachchidanand Vaidya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19758/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 7:30 a.m.) > > > Review request for cloudstack and Rajesh Battala. > > > Repository: cloudstack-git > > > Description > ------- > > - Added new Network Service Provider "JuniperContrailvSRX". > - Impelemted an element (ContrailVSrxElement) to support this Network > Service Provider. > vSRX element currently supports only sourceNAT. It will be enhanced later > to support > more features. > - Changes to service-instance creation code to use left virtual-network's > SourceNAT addr > as an interface address on vSRX instance's Public-network interface. > > > Diffs > ----- > > api/src/com/cloud/network/Network.java ef3bcdf > > plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml > 99ab02e > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java > f34eacc > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java > 49060f1 > > Diff: https://reviews.apache.org/r/19758/diff/ > > > Testing > ------- > > Performed unit tests with vSRX network service provider. Also other unit > tests pass in local testbed. > > > Thanks, > > Sachchidanand Vaidya > >
