Sebastien, We fixed all the pep8 issues in marvin branch, I think these issues popped up when we tried to rebase marvin branch with master before merging. All these issues are fixed now. We have plans to take up some more enhancements to marvin ,during which, we can take up fixing the issues that arise after running pylint/flake8 as you suggested here.
We can have marvin in pypi, however, before doing that we need to have few things sorted out like versioning for different CS releases. Thanks, ~Talluri On 29/04/14 1:33 pm, "sebgoa" <run...@gmail.com> wrote: >Thanks Talluri for doing the merge, > >I did notice a couple minor pep8 issues. > >More importantly It would be nice to run all the python files through >pylint, it helps catch optimization points in the code as well as flat >out errors. > >Are you going to push this new version of Marvin to pypi ? > >-Sebastien > >On Apr 23, 2014, at 8:21 AM, SrikanteswaraRao Talluri ><srikanteswararao.tall...@citrix.com> wrote: > >> As there are no more comments/objections for this merge, I have Merged >> Œmarvin¹ branch into master. Now all these changes are available in >>master. >> >> ~Talluri >> >> On 17/04/14 11:15 am, "Santhosh Edukulla" <santhosh.eduku...@citrix.com> >> wrote: >> >>> 1. After successful creation of datacenter, deploydatacenter will >>>export >>> the created configuration, so this basically is the serialized >>> information of entries created with their ids. >>> >>> 2. Delete only deletes the datacenter and not recreate, all the >>>previous >>> exported configuration while creating, will be used for deleting. >>> Basically, the export or import configuration is not from CS, it is >>>what >>> deployDatacenter exported when it created a datacenter, so exporting >>>for >>> one zone etc is not possible. >>> >>> Doc: Yes, we will update wherever applicable. >>> >>> Santhosh >>> ________________________________________ >>> From: Rajani Karuturi [rajani.karut...@citrix.com] >>> Sent: Thursday, April 17, 2014 12:40 AM >>> To: dev@cloudstack.apache.org >>> Cc: Srikanteswararao Talluri >>> Subject: Re: [Merge]: marvin branch to master >>> >>> Hi Santosh, >>> >>> What is the command to export the current datacenter configuration? Is >>> this added only to help delete? >>> >>> looks like delete is actually delete and recreate. Is there a way to >>>just >>> delete? If I have more than one zone configured and want to delete one >>>of >>> them, is it possible? >>> >>> post merge, it would be good to update the existing [marvin doc] >>> >>> Happy mergingŠ >>> >>> [marvin doc] >>> >>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+ >>>wi >>> th+Python >>> >>> ~Rajani >>> >>> >>> >>> On 16-Apr-2014, at 11:18 pm, Santhosh Edukulla >>> <santhosh.eduku...@citrix.com<mailto:santhosh.eduku...@citrix.com>> >>>wrote: >>> >>> Hi Team, >>> >>> We would like to merge marvin branch changes to master. We did few >>> changes as mentioned below. We rebased it against master and tested the >>> changes we did. >>> >>> >>>https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=3857052 >>>0 >>> >>> >>> Thanks! >>> Santhosh >>> >> >
