----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20557/#review41524 -----------------------------------------------------------
Ship it! Applied to 4.3 with commit: 08997a9ba37d939dc6e546c632daf93b2b04e825 I re-wrote the patch and committed to master as well with: 744e2a54e8b05d8136382664d8e5b9e3649fe88e Thanks for the patch, please make sure to tell us if there is more issue with this. You can mark the review as submitted. - Sebastien Goasguen On April 23, 2014, 12:47 p.m., Pierre-Yves Ritschard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20557/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 12:47 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-6472 > https://issues.apache.org/jira/browse/CLOUDSTACK-6472 > > > Repository: cloudstack-git > > > Description > ------- > > This is a review request for CLOUDSTACK-6472 "listUsageRecords generates NPEs > for expunging instances" > > The patch is against the 4.3 branch > > > Diffs > ----- > > server/src/com/cloud/api/ApiResponseHelper.java e543d1c > > Diff: https://reviews.apache.org/r/20557/diff/ > > > Testing > ------- > > > Thanks, > > Pierre-Yves Ritschard > >
