-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20611/#review41245
-----------------------------------------------------------

Ship it!


Already fixed.

- Chiradeep Vittal


On April 23, 2014, 5:59 p.m., Yichi Lu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20611/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 5:59 p.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal and Rohit Yadav.
> 
> 
> Repository: cloudstack-cloudmonkey
> 
> 
> Description
> -------
> 
> There are two calls to the method make_request() in cloudmonkey/requester.py; 
> one of them is for async apis only. Due to my oversight, expires is missing 
> in the method call for async apis. This request fixed it. 
> 
> 
> Diffs
> -----
> 
>   cloudmonkey/requester.py 170437d 
> 
> Diff: https://reviews.apache.org/r/20611/diff/
> 
> 
> Testing
> -------
> 
> first created a dummy account. Next (where deleteAccount is an async api):
> python cloudmonkey/cloudmonkey.py deleteAccount id=....
> 
> 
> Thanks,
> 
> Yichi Lu
> 
>

Reply via email to