Santosh, Can you let me know ur thoughs If the review comments have been adequately addressed and the changes looks ok?
Thanks Saurav On Tue, Apr 15, 2014 at 5:43 PM, Saurav Lahiri <saurav.lah...@sungard.com>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20123/ > Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, and > Rajesh Battala. > By Saurav Lahiri. > > *Updated April 15, 2014, 12:13 p.m.* > Changes > > Looks like the earlier patch had a problem. Please use this one instead which > addresses the review comments. > > *Repository: * cloudstack-git > Description > > With multiple java processes writing to the same logfile, each is not aware > of the log4j's internal counter state, this needs to be prevented. So before > starting new java process via the _run.sh , a check is made to ensure that > there are no existing java processes running. This will prevent multiple java > process writing to the same log file namely cloud.out. > > Testing > > Tested the changes with console proxy vm and secondary storage vm. They start > and stop as expected. > > Diffs (updated) > > - systemvm/patches/debian/config/etc/init.d/cloud (83853bc) > - systemvm/scripts/run.sh (146d96f) > - systemvm/scripts/utils.sh (PRE-CREATION) > > View Diff <https://reviews.apache.org/r/20123/diff/> >
