> On March 24, 2014, 3:01 p.m., Sebastien Goasguen wrote: > > I applied it to master (future 4.5) > > > > d5333f4596460c7123b66ad5c19fc69442696ea2 > > > > and 4.4 branch. > > Please test these new branches from source as I did not have time to test > > it. > > > > thanks a lot for the patch > > Sebastien Goasguen wrote: > Dmitry, can you add the apache license headers and remove the @author > tags. > > if you do it today, I will apply asap to avoid breaking the license > checker. > > thanks, I should have caught that. > > Sebastien Goasguen wrote: > I did not want to break the license check much longer (RAT) so I > corrected it: > > f848c779c032bafa05bf6be269cceb34c942149a > > you can mark the review as 'submitted' > > thanks
no strange problems with CloudStackApi now - Dmitry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17586/#review38297 ----------------------------------------------------------- On April 21, 2014, 8:26 p.m., Dmitry Batkovich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17586/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 8:26 p.m.) > > > Review request for cloudstack and Sebastien Goasguen. > > > Repository: cloudstack-git > > > Description > ------- > > * CloudStackClient.java http request mechanism replaced from GET requests to > POST for supporting EC2 requests larger than 2KB > * SSL enabling fixed in EC2Engine.java > > > Diffs > ----- > > awsapi/conf/ec2-service.properties.in 82f5ad8 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214 > awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5 > awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210 > awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96 > awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION > awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef > awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68 > awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION > awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a > awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59 > awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION > > Diff: https://reviews.apache.org/r/17586/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > cloudstack_api_post_and_ssl_fix.patch > > https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch > > > Thanks, > > Dmitry Batkovich > >
