will you add the license header then?
On Thu, Apr 17, 2014 at 7:36 PM, Laszlo Hornyak <laszlo.horn...@gmail.com>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17335/ > > On April 17th, 2014, 2:08 p.m. UTC, *daan Hoogland* wrote: > > Lazslo, you still want this reviewed/applied? > > Yes a review would be nice > > > - Laszlo > > On February 2nd, 2014, 5:03 p.m. UTC, Laszlo Hornyak wrote: > Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min > Chen. > By Laszlo Hornyak. > > *Updated Feb. 2, 2014, 5:03 p.m.* > *Repository: * cloudstack-git > Description > > - changed type parameters on details map in CreateSecondaryStagingStoreCmd - > <String, String> was misleading since the it can not work with a string value > and it is never a string > - introducing the type parameters allowed some simplifications in > getDetails() > - added unit test > > Testing > > - all unit tests passed > - checked all references and usage of the details field, injection with the > @Parameter annotation > > Diffs > > - > api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java > (1480e75) > - > api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java > (PRE-CREATION) > > View Diff <https://reviews.apache.org/r/17335/diff/> > -- Daan
