----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20313/#review40371 -----------------------------------------------------------
Ship it! Ship It! - Devdeep Singh On April 14, 2014, 8:41 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20313/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 8:41 a.m.) > > > Review request for cloudstack, Devdeep Singh and Rajesh Battala. > > > Bugs: CLOUDSTACK-6400 > https://issues.apache.org/jira/browse/CLOUDSTACK-6400 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6400: Occasionally VM is not deleted from back-end when it is > stopped from Hyper-V manager and then destroyed-expunged from CS. With this > patch hyper-v agent will delete the stopped VMs on hyper-v host so that > hyper-v host is in consistent state with cloudstack. This patch will also > make sure that VMs which are in process of creation they are returned as in > PowerOn state so that they are not accidentally deleted. Notes are added to > vm to identify whether it is created by cloudstack or not > > > Diffs > ----- > > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs > 4f4c14e > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs > 8c682ad > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs > 79fd0bc > > Diff: https://reviews.apache.org/r/20313/diff/ > > > Testing > ------- > > verified > 1. if vm is stopped from hyper-v manager then it should be automatically > deleted > 2. vms which is in process of creation is not getting accidentally deleted > 3. proper notes are added to vm created by cloudstack > > > Thanks, > > Anshul Gangwar > >
