----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20210/#review40034 -----------------------------------------------------------
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java <https://reviews.apache.org/r/20210/#comment72835> Why do we need to update the old entry and not create a new one ? We should handle listTemplate not returning the destroyed result for the template ? engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java <https://reviews.apache.org/r/20210/#comment72834> Changing the state not using state machine is bad practice. engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImpl.java <https://reviews.apache.org/r/20210/#comment72832> method name says its zone but then you are passing the image store ? server/src/com/cloud/template/HypervisorTemplateAdapter.java <https://reviews.apache.org/r/20210/#comment72836> The comment doesnt match what you are doing. server/src/com/cloud/template/HypervisorTemplateAdapter.java <https://reviews.apache.org/r/20210/#comment72831> Why is this required ? This should happen via state machine and not like this. Are you seeing the destroyed not being set ? - Nitin Mehta On April 10, 2014, 3:04 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20210/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 3:04 p.m.) > > > Review request for cloudstack, Kishan Kavala and Min Chen. > > > Bugs: CLOUDSTACK-6377 > https://issues.apache.org/jira/browse/CLOUDSTACK-6377 > > > Repository: cloudstack-git > > > Description > ------- > > List templates returns destroyed temples when copying the same template after > deleting. > https://issues.apache.org/jira/browse/CLOUDSTACK-6377 > > > Diffs > ----- > > > engine/api/src/org/apache/cloudstack/storage/datastore/db/TemplateDataStoreDao.java > 048ce22 > > engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java > d9a5164 > > engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImpl.java > f5140e0 > server/src/com/cloud/template/HypervisorTemplateAdapter.java 963aec9 > > Diff: https://reviews.apache.org/r/20210/diff/ > > > Testing > ------- > > Tested on 4.2 > > > Thanks, > > bharat kumar > >
