-----Original Message----- From: Frank Zhang [mailto:frank.zh...@citrix.com] Sent: Monday, April 07, 2014 4:43 PM To: cloudstack-...@incubator.apache.org Subject: Maven style checker issue
I struggled two days to fix my several tens of files for trailing space, tab, unused imports... manually(vim + sed). Yes, manually because I am using Intellj the ApacheCloudStack formatter profile won't work for me, even though Intellj 13 claims supporting Eclipse formatter profile, it doesn't work at all. I can understand most of rules except below: 1. Using the '.*' form of import should be avoided This totally breaks Intellj and some J2SE library. Intellj will automatically use a single ".*" to replace multiple separate imports if all imports are from the same package. And if you use JAXB which is J2SE XML standard library, you will see it puts "javax.xml.bind.annotation.*" on every generated java-xml binding. 2. Name 'SSHPublicKey' must match pattern '^[a-z][a-zA-Z0-9]*$'. What's wrong in using SSH instead of Ssh? I don't know what standard these rules are based on, and I don't think there is a world agreed standard in Java for code format. When we defined these rules, did we widely consider people not using Eclipse? Do we really think these rules make our code look better(to be honest, I don't know what's wrong with trailing space and tab, remember Java is not Python)? >From my two days experience, it really makes developer's life hard
