yes, that is correct.
On Mon, Apr 7, 2014 at 3:27 PM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > Alex, one more question. Is this patch meant to be a part of master branch > only (4.5)? I guess so as your changes affect 4.4-4.5 db upgrade path. > > Please confirm, > Alena. > > On 4/7/14, 12:13 PM, "Alex Ough" <alex.o...@sungard.com> wrote: > > > > >----------------------------------------------------------- > >This is an automatically generated e-mail. To reply, visit: > >https://reviews.apache.org/r/20099/ > >----------------------------------------------------------- > > > >(Updated April 7, 2014, 7:13 p.m.) > > > > > >Review request for cloudstack. > > > > > >Changes > >------- > > > >The is the patch for the core changes. > > > > > >Repository: cloudstack-git > > > > > >Description > >------- > > > >This is the review request for the core changes related with #17790 that > >has only the new plugin codes. > > > > > >Diffs (updated) > >----- > > > > api/src/com/cloud/domain/Domain.java 365a705 > > api/src/com/cloud/event/EventTypes.java 39ef710 > > api/src/com/cloud/user/Account.java b912e51 > > api/src/com/cloud/user/AccountService.java 7e37b38 > > api/src/com/cloud/user/User.java 36e9028 > > api/src/com/cloud/user/UserAccount.java c5a0637 > > api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 > > api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae > > > >api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java > >f6743ba > > > >api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.jav > >a b08cbbb > > api/src/org/apache/cloudstack/api/response/AccountResponse.java 2e50c51 > > api/src/org/apache/cloudstack/api/response/DomainResponse.java 0c0281e > > api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 > > api/src/org/apache/cloudstack/api/response/UserResponse.java 40e1561 > > api/src/org/apache/cloudstack/region/Region.java df64e44 > > api/src/org/apache/cloudstack/region/RegionService.java afefcc7 > > api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java > >10c3d85 > > client/pom.xml d8dbde7 > > > >engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core > >-daos-context.xml 489b37d > > engine/schema/src/com/cloud/domain/DomainVO.java f6494b3 > > engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 > > engine/schema/src/com/cloud/user/UserAccountVO.java cef9239 > > engine/schema/src/com/cloud/user/UserVO.java 68879f6 > > engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b > > framework/db/src/com/cloud/utils/db/Attribute.java 82c2bdb > > framework/db/src/com/cloud/utils/db/GenericDao.java cb401cd > > framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad > > framework/db/src/com/cloud/utils/db/SqlGenerator.java befe34b > > framework/db/test/com/cloud/utils/db/GenericDaoBaseTest.java aef0c69 > > framework/db/test/com/cloud/utils/db/SqlGeneratorTest.java PRE-CREATION > > > >plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/netwo > >rk/contrail/management/MockAccountManager.java 957f708 > > plugins/pom.xml 9b391b8 > > > >server/resources/META-INF/cloudstack/core/spring-server-core-managers-cont > >ext.xml fc1c7e2 > > server/src/com/cloud/api/ApiDispatcher.java 95074e2 > > server/src/com/cloud/api/ApiResponseHelper.java 38f2f0b > > server/src/com/cloud/api/dispatch/ParamProcessWorker.java e9bdd8b > > server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java ecd97c7 > > server/src/com/cloud/api/query/dao/UserAccountJoinDaoImpl.java 923a238 > > server/src/com/cloud/api/query/vo/AccountJoinVO.java 8d642ed > > server/src/com/cloud/api/query/vo/UserAccountJoinVO.java ed29284 > > server/src/com/cloud/event/ActionEventUtils.java 28e5680 > > server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 > > server/src/com/cloud/user/AccountManager.java 03bf842 > > server/src/com/cloud/user/AccountManagerImpl.java 2070ee6 > > server/src/com/cloud/user/DomainManager.java f72b18a > > server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 > > server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 > > server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 > > server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 > > server/test/com/cloud/api/dispatch/ParamProcessWorkerTest.java 12051a6 > > server/test/com/cloud/user/MockAccountManagerImpl.java f373cba > > server/test/com/cloud/user/MockDomainManagerImpl.java 7dddefb > > server/test/org/apache/cloudstack/region/RegionManagerTest.java d7bc537 > > setup/db/db/schema-440to450.sql 2bd5386 > > ui/scripts/regions.js 66dae8c > > > >Diff: https://reviews.apache.org/r/20099/diff/ > > > > > >Testing > >------- > > > >1. Successfully tested real time synchronization as soon as resources are > >created/deleted/modified in one region. > >2. Successfully tested full scans to synchronize resources that were > >missed during real time synchronization because of any reasons like > >network connection issues. > >3. The tests were done manually and also automatically by randomly > >generating changes each region. > > > > > >Thanks, > > > >Alex Ough > > > > >
