----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19941/#review39692 -----------------------------------------------------------
cloudmonkey/requester.py <https://reviews.apache.org/r/19941/#comment72272> Seems overly complicated! This should work? datetime.utcnow() + timedelta(minutes=expires) cloudmonkey/requester.py <https://reviews.apache.org/r/19941/#comment72273> Can you make this configurable in the config? - Chiradeep Vittal On April 2, 2014, 4:39 p.m., Yichi Lu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19941/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 4:39 p.m.) > > > Review request for cloudstack, Chiradeep Vittal and Rohit Yadav. > > > Repository: cloudstack-git > > > Description > ------- > > When submitting cloudmonkey commands, include signature version (3) and > expiration date (10 minutes) to the commnds > > > Diffs > ----- > > cloudmonkey/requester.py b06e1fc > server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java 7a73b8a > > Diff: https://reviews.apache.org/r/19941/diff/ > > > Testing > ------- > > The request for area west of utc (0): > request: [('signatureversion', '3'), ('apiKey', > '1h41nLKEg-3uO3TSWBQ_twEBfWGY2Uu0WrWkbvgWA_ogvKF-6By6GGTscPjyktVWHVAnmSD3BIXA9sNWMcfidQ'), > ('command', u'listUsers'), ('response', 'json'), ('expires', > '2014-04-01T17:30:26+0600')] > seen by ApiServer.java: > org.apache.cloudstack.api.command.admin.user.ListUsersCmd@5574c56e, params: > {expires=2014-04-01T17:30:26+0600, signatureversion=3, httpmethod=GET, > apiKey=1h41nLKEg-3uO3TSWBQ_twEBfWGY2Uu0WrWkbvgWA_ogvKF-6By6GGTscPjyktVWHVAnmSD3BIXA9sNWMcfidQ, > signature=i6qW1tC3y1oIvXIHc29EUs2nSR8=} > > The one for area east of utc(0): > request: [('signatureversion', '3'), ('apiKey', > '1h41nLKEg-3uO3TSWBQ_twEBfWGY2Uu0WrWkbvgWA_ogvKF-6By6GGTscPjyktVWHVAnmSD3BIXA9sNWMcfidQ'), > ('command', u'listUsers'), ('response', 'json'), ('expires', > '2014-04-01T21:16:45-0630')] > org.apache.cloudstack.api.command.admin.user.ListUsersCmd@3484bd18, params: > {expires=2014-04-01T21:16:45-0630, signatureversion=3, httpmethod=GET, > apiKey=1h41nLKEg-3uO3TSWBQ_twEBfWGY2Uu0WrWkbvgWA_ogvKF-6By6GGTscPjyktVWHVAnmSD3BIXA9sNWMcfidQ, > signature=9RDS6RWAz9vs4XHa6LRXxtd7MhQ=} > > > Thanks, > > Yichi Lu > >
