Hi Alena, I still see errors with "display" in StorageAllocatorTest and VmSnapshotDaoTest in 4.4.
Just wondering if this was expected as perhaps you haven't had a chance to address them yet. Thanks! On Mon, Mar 17, 2014 at 10:58 AM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > That¹s due to my changes, I will fix StorageAllocatorTest class. > > I haven¹t caught it because "mvn clean install -P developer,systemvm² > wasn¹t failing. Looks like this test is not a part of unit test suite run > by maven? > > > Thanks, > Alena. > > On 3/15/14, 8:17 AM, "Laszlo Hornyak" <laszlo.horn...@gmail.com> wrote: > > >The commiter may not have realized that this profile must be activated to > >compile the module, also there are no jenkins builds configured to compile > >this module and this is broken for about a month. No one noticed until > >Mike > >told about it. Maybe the build-master-noredist could be a good > >candidate... > > > > > >On Sat, Mar 15, 2014 at 3:51 PM, Daan Hoogland > ><daan.hoogl...@gmail.com>wrote: > > > >> someone hastily checked in some code without running unit tests! > >> Unforgivable, especially if it was a refactoring. I am kind of lenient > >> on quick bug fixes so i say this with some restraint. (excuse my > >> Dutch) > >> > >> Do we have a merge conflict between two features or refactorings here? > >> > >> On Sat, Mar 15, 2014 at 3:37 PM, Laszlo Hornyak > >> <laszlo.horn...@gmail.com> wrote: > >> > No, it is really broken, 'display' should be replaced with a boolean > >> > expression. I believe it was something left behind after a > >>refactoring. > >> > > >> > > >> > On Sat, Mar 15, 2014 at 3:17 PM, Daan Hoogland > >><daan.hoogl...@gmail.com > >> >wrote: > >> > > >> >> so, is eclipse wrong? > >> >> > >> >> On Sat, Mar 15, 2014 at 11:02 AM, Laszlo Hornyak > >> >> <laszlo.horn...@gmail.com> wrote: > >> >> > you are not alone :) > >> >> > > >> >> > > >> >> > On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski < > >> >> > mike.tutkow...@solidfire.com> wrote: > >> >> > > >> >> >> "display cannot be resolved to a variable" > >> >> >> > >> >> >> http://i.imgur.com/Jz2swFS.png > >> >> >> > >> >> >> -- > >> >> >> *Mike Tutkowski* > >> >> >> *Senior CloudStack Developer, SolidFire Inc.* > >> >> >> e: mike.tutkow...@solidfire.com > >> >> >> o: 303.746.7302 > >> >> >> Advancing the way the world uses the > >> >> >> cloud<http://solidfire.com/solution/overview/?video=play> > >> >> >> *(tm)* > >> >> >> > >> >> > > >> >> > > >> >> > > >> >> > -- > >> >> > > >> >> > EOF > >> >> > >> >> > >> >> > >> >> -- > >> >> Daan > >> >> > >> > > >> > > >> > > >> > -- > >> > > >> > EOF > >> > >> > >> > >> -- > >> Daan > >> > > > > > > > >-- > > > >EOF > > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud<http://solidfire.com/solution/overview/?video=play> *(tm)*
