----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19780/#review38881 -----------------------------------------------------------
Ship it! Ship It! - Abhinandan Prateek On March 28, 2014, 6:51 a.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19780/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 6:51 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and daan Hoogland. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6291 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6291 > > > Repository: cloudstack-git > > > Description > ------- > > Previously we were checking environment variables to decide the needed > dependencies are installed or not. This will some extra effort to the admin > to set them before start installation of ACS. So removed that dependency and > checking through registry to verify the same. > > > Diffs > ----- > > scripts/installer/windows/acs.wxs 9456a5a > > Diff: https://reviews.apache.org/r/19780/diff/ > > > Testing > ------- > > Tested on windows 2008R2 instance. Tested for the following use cases > 1. Java is not installed > 2. tomcat is not installed > 3. 7z is not installed. > > > Thanks, > > Damodar Reddy Talakanti > >