> On March 27, 2014, 5:02 p.m., Alena Prokharchyk wrote: > > Suresh, your fix contradicts with whatever you said in your previous > > comment. You said that your contrail element will play the role of the > > internal load Balancer. In that case, you should have added the Service LB > > with capability LbSchemas="internal" to your contrail provider > > implementation. > > > > The current fix though implies that the separate Internal LB vm will be > > started? Please elaborate. > > Suresh Balineni wrote: > I wanted to re-use the existing Internal LB element as is except required > Nic resources should be implemented by Contrail VRouter. > >
Suresh, InternalLbElement is being managed by InternalLBElementManager. The nics are created there. If you want the rules to be programmed on your VPC contrail element, use your VPC contrail element as a provider for internal lb. With the current code in the patch, the internal lb vm will be created as a separate vm from your contrail vm, with the nics configured the standard way. - Alena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18552/#review38754 ----------------------------------------------------------- On March 27, 2014, 12:42 a.m., Suresh Balineni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18552/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 12:42 a.m.) > > > Review request for cloudstack and Alena Prokharchyk. > > > Repository: cloudstack-git > > > Description > ------- > > Internal LB support for Juniper contrail VPC implementation. > > - This implementation just extends the existing implementation of internal lb. > - New element uses juniper contrail network offering so that nics are > impelemented by contrail element. > - LB VM deployment functionality is reused (new element is extended from > existing Internal LB element implementation). > > > Diffs > ----- > > plugins/network-elements/juniper-contrail/pom.xml 8c6877d > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java > 01be7db > server/src/com/cloud/network/vpc/VpcManagerImpl.java fe49981 > > Diff: https://reviews.apache.org/r/18552/diff/ > > > Testing > ------- > > Tested LB VM deployment. Traffic tests are done. > > > Thanks, > > Suresh Balineni > >
