----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19675/ -----------------------------------------------------------
Review request for cloudstack and Brian Federle. Repository: cloudstack-git Description ------- Added the ability to display a warning icon on confirmation dialogs, rendered via both dialog.createForm() and dialog.confirm(): dialog.js: confirm() and createForm() functions: – added isWarning parameter. – when used with isWarning: true, will show the warning icon in title bar (see .ui-dialog.warning .ui-dialog-title in cloudstack3.css). detailView.js: - passing isWarning argument to dialog.confirm(). cloudstack3.css: - added .ui-dialog.warning .ui-dialog-title for the title bar with warning (white exclamation mark on orange circle) icon. instances.js: - using isWarning for destroy instance action. network.js: - using isWarning for delete network action. My intention is to change all ‘delete’ confirmation dialogs to display the warning icon. Maybe other dialogs could use this as well, especially disruptive actions , like for example ‘restart network’. Diffs ----- ui/css/cloudstack3.css f5582b6 ui/scripts/instances.js d219e6d ui/scripts/network.js f82a295 ui/scripts/ui/dialog.js 82e7fd4 ui/scripts/ui/widgets/detailView.js 4c5aeea Diff: https://reviews.apache.org/r/19675/diff/ Testing ------- Thanks, Mihaela Stoica
