Hi, I have just looked into this, looks quite safe to me and follows the conventions of the code.
However, what about a little change in the conventions? Wouldn't it be more simple not to return null if the operation failed? This could help simplifying the code by eliminating lots of null-checks, and also the service implementations could become more simple. On Tue, Mar 25, 2014 at 4:04 PM, Alex Hitchins <alex.hitch...@shapeblue.com>wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19616/ > ----------------------------------------------------------- > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Added check for returned null, if received then throw exception. > > > Diffs > ----- > > server/src/com/cloud/storage/VolumeApiServiceImpl.java 5ffa99b > > Diff: https://reviews.apache.org/r/19616/diff/ > > > Testing > ------- > > Compiled & ran. > > > Thanks, > > Alex Hitchins > > -- EOF
