----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19588/#review38427 -----------------------------------------------------------
Still does not apply. $ git apply --check ~/Desktop/5.patch error: patch failed: test/selenium/browser/__init__.py:0 error: test/selenium/browser/__init__.py: patch does not apply error: test/selenium/browser/firefox.py: already exists in working directory error: patch failed: test/selenium/browser/firefox.py:1 error: test/selenium/browser/firefox.py: patch does not apply error: test/selenium/common/Global_Locators.py: already exists in working directory error: patch failed: test/selenium/common/Global_Locators.py:73 error: test/selenium/common/Global_Locators.py: patch does not apply error: patch failed: test/selenium/common/__init__.py:0 error: test/selenium/common/__init__.py: patch does not apply error: test/selenium/common/shared.py: already exists in working directory error: patch failed: test/selenium/common/shared.py:1 error: test/selenium/common/shared.py: patch does not apply error: patch failed: test/selenium/cspages/__init__.py:0 error: test/selenium/cspages/__init__.py: patch does not apply error: test/selenium/cspages/dashboard/__init__.py: already exists in working directory error: test/selenium/cspages/dashboard/dashboardpage.py: already exists in working directory error: test/selenium/cspages/login/__init__.py: already exists in working directory error: test/selenium/cspages/login/loginpage.py: already exists in working directory error: patch failed: test/selenium/cspages/login/loginpage.py:76 error: test/selenium/cspages/login/loginpage.py: patch does not apply error: patch failed: test/selenium/cstests/__init__.py:0 error: test/selenium/cstests/__init__.py: patch does not apply error: test/selenium/cstests/regressiontests/__init__.py: already exists in working directory error: patch failed: test/selenium/cstests/smoketests/__init__.py:0 error: test/selenium/cstests/smoketests/__init__.py: patch does not apply error: test/selenium/cstests/smoketests/global_settings_test.py: already exists in working directory error: test/selenium/cstests/smoketests/login_logout_test.py: already exists in working directory error: patch failed: test/selenium/cstests/smoketests/login_logout_test.py:1 error: test/selenium/cstests/smoketests/login_logout_test.py: patch does not apply error: patch failed: test/selenium/cstests/smoketests/login_logout_test.py:58 error: test/selenium/cstests/smoketests/login_logout_test.py: patch does not apply error: test/selenium/cstests/smoketests/navigation_test.py: already exists in working directory error: test/selenium/cstests/smoketests/smokecfg.py: already exists in working directory error: patch failed: test/selenium/cstests/smoketests/smokecfg.py:1 error: test/selenium/cstests/smoketests/smokecfg.py: patch does not apply I think you still have the previous commits that you made in the branch you are writing those new tests. So when you created the patch it still includes them. - Sebastien Goasguen On March 24, 2014, 4:40 p.m., Yichi Lu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19588/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 4:40 p.m.) > > > Review request for cloudstack and Sebastien Goasguen. > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6015 > Following tests are new (need to be run in the order displayed): > adduseraccount_test.py > adduser_test.py > login_logout_as_JohnD_test.py (new account's username is JohnD) > deleteuser_test.py > deleteuseraccount_test.py > > > Diffs > ----- > > test/selenium/browser/__init__.py e69de29 > test/selenium/browser/firefox.py PRE-CREATION > test/selenium/browser/firefox.py e89619f > test/selenium/common/Global_Locators.py PRE-CREATION > test/selenium/common/Global_Locators.py 1b03d7f > test/selenium/common/__init__.py e69de29 > test/selenium/common/shared.py PRE-CREATION > test/selenium/common/shared.py 39f2d33 > test/selenium/common/shared.py b4f537f > test/selenium/cspages/__init__.py e69de29 > test/selenium/cspages/accounts/accountspage.py PRE-CREATION > test/selenium/cspages/accounts/userspage.py PRE-CREATION > test/selenium/cspages/cspage.py PRE-CREATION > test/selenium/cspages/dashboard/__init__.py PRE-CREATION > test/selenium/cspages/dashboard/dashboardpage.py PRE-CREATION > test/selenium/cspages/dashboard/dashboardpage.py 4394199 > test/selenium/cspages/login/__init__.py PRE-CREATION > test/selenium/cspages/login/loginpage.py PRE-CREATION > test/selenium/cspages/login/loginpage.py 39e4295 > test/selenium/cspages/login/loginpage.py e7795d9 > test/selenium/cspages/loginpage.py PRE-CREATION > test/selenium/cspages/loginpage.py c6e736c > test/selenium/cstests/__init__.py e69de29 > test/selenium/cstests/regressiontests/__init__.py PRE-CREATION > test/selenium/cstests/smoketests/__init__.py e69de29 > test/selenium/cstests/smoketests/adduser_test.py PRE-CREATION > test/selenium/cstests/smoketests/adduseraccount_test.py PRE-CREATION > test/selenium/cstests/smoketests/deleteuser_test.py PRE-CREATION > test/selenium/cstests/smoketests/deleteuseraccount_test.py PRE-CREATION > test/selenium/cstests/smoketests/global_settings_test.py PRE-CREATION > test/selenium/cstests/smoketests/login_logout_as_JaneD_test.py PRE-CREATION > test/selenium/cstests/smoketests/login_logout_as_JaneD_test.py 3e5883e > test/selenium/cstests/smoketests/login_logout_as_JohnD_test.py PRE-CREATION > test/selenium/cstests/smoketests/login_logout_test.py PRE-CREATION > test/selenium/cstests/smoketests/login_logout_test.py 49c545a > test/selenium/cstests/smoketests/login_logout_test.py 66fcc4a > test/selenium/cstests/smoketests/navigation_test.py PRE-CREATION > test/selenium/cstests/smoketests/smokecfg.py PRE-CREATION > test/selenium/cstests/smoketests/smokecfg.py 37d55b3 > test/selenium/cstests/smoketests/smokecfg.py 8bbb350 > > Diff: https://reviews.apache.org/r/19588/diff/ > > > Testing > ------- > > tested against CloudStack 4.5.0-SNAPSHOT. Patch generated against the latest > master. > > > Thanks, > > Yichi Lu > >
