Perfect
On Thu, Mar 20, 2014 at 12:55 PM, Brian Federle <brian.fede...@citrix.com>wrote: > Those suggestions sound good. Here are the changes I will make in the UI: > > - Change icon to use a 'recycle' symbol, to avoid confusion w/ reboot VM > - Rename action(s) to reflect the name of the API calls. > - Update the confirm dialog to say, "This action will restore the VM to a > fresh root disk. After this action, the current root disk will be attached > to the VM." > > -Brian > > On Mar 20, 2014, at 11:46 AM, Mike Tutkowski <mike.tutkow...@solidfire.com> > wrote: > > > I think with the addition of detailed confirmation info that that is a > good > > solution. > > > > Thanks! > > > > > > On Thu, Mar 20, 2014 at 12:44 PM, Jessica Wang <jessica.w...@citrix.com > >wrote: > > > >> And also provide detailed info in confirmation dialog when clicking the > >> icon that fires restoreVirtualMachine API. > >> > >> e.g. "This action will restore the VM to a fresh new root disk. > >> After this action, the current root disk wll be destroyed and a new root > >> disk will be attached to the VM." > >> > >> > >> Harikrishna, > >> do you any suggestion for the text in confirmation dialog? > >> > >> > >> -----Original Message----- > >> From: Jessica Wang [mailto:jessica.w...@citrix.com] > >> Sent: Thursday, March 20, 2014 11:32 AM > >> To: Mike Tutkowski > >> Cc: Brian Federle; Harikrishna Patnala; Alena Prokharchyk; > >> dev@cloudstack.apache.org; Stephen Turner > >> Subject: RE: Resetting a VM is broken? > >> > >> How about we just match text with API name? > >> > >> i. Label the icon that fires recoverVirtualMachine API as "Recover". > >> ii. Label the icon that fires restoreVirtualMachine API as "Restore". > >> > >> > >> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > >> Sent: Thursday, March 20, 2014 11:29 AM > >> To: Jessica Wang > >> Cc: Brian Federle; Harikrishna Patnala; Alena Prokharchyk; > >> dev@cloudstack.apache.org; Stephen Turner > >> Subject: Re: Resetting a VM is broken? > >> > >> OK, thanks for the history there. > >> > >> What about the text we're using? Are we OK with Reset VM, for example? > >> > >> Thanks! > >> > >> On Thu, Mar 20, 2014 at 12:26 PM, Jessica Wang <jessica.w...@citrix.com > >> <mailto:jessica.w...@citrix.com>> wrote: > >> Mike, > >> > >> Right. > >> > >> The history is recoverVirtualMachine API was created several years ago, > >> restoreVirtualMachine didn't exist yet at that time. > >> So, the icon that fires recoverVirtualMachine API was labeled as > "Restore" > >> at that time. > >> > >> restoreVirtualMachine API came along several years later. > >> Then, since label "Restore" has already taken, the icon that fires > >> restoreVirtualMachine API was therefore labeled as "Reset". > >> > >> The result is indeed weird. > >> We'll fix the label to match API name. > >> > >> Jessica > >> > >> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com<mailto: > >> mike.tutkow...@solidfire.com>] > >> Sent: Thursday, March 20, 2014 11:03 AM > >> To: Jessica Wang > >> Cc: Brian Federle; Harikrishna Patnala; Alena Prokharchyk; > >> dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>; Stephen > >> Turner > >> > >> Subject: Re: Resetting a VM is broken? > >> > >> Thanks, Jessica > >> > >> The even weirder part, though, is that the text Restore maps to the > >> recoverVirtualMachine API and the text Reset VM maps to the > >> restoreVirtualMachine. > >> > >> On Thu, Mar 20, 2014 at 11:58 AM, Jessica Wang <jessica.w...@citrix.com > >> <mailto:jessica.w...@citrix.com>> wrote: > >>> [Mike Tutkowski] Unless I'm reading this incorrectly, it looks like > >>> label.action.restore.instance (Restore Instance) maps to > >> recoverVirtualMachine > >>> and > >>> label.resetVM (Reset VM) maps to restoreVirtualMachine > >> Yes, this is confusing. > >> I'll file an UI bug to match icon label with API name. > >> i.e. The icon that fires recoverVirtualMachine API will be labeled as > >> "Recover" > >> and the icon that fires restoreVirtualMachine API will be labeled as > >> "Restore" > >> > >> > >> -----Original Message----- > >> From: Brian Federle > >> Sent: Thursday, March 20, 2014 10:29 AM > >> To: Alena Prokharchyk > >> Cc: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>; Brian > >> Federle; Jessica Wang; Mike Tutkowski; Harikrishna Patnala > >> Subject: Re: Resetting a VM is broken? > >>>> the Reset Vm option is presented as a button unlike the icons > >> I think this was because all the other icons we tried to represent this > >> with were too confusing to users - they were clicking on 'reset VM' > >> thinking it was 'reboot VM' - then as a last minute fix the decision > was to > >> just to show a text label. > >> > >> Any ideas from anyone on what would be a good icon representation? > >> > >> -Brian > >> > >> On Mar 19, 2014, at 3:02 PM, Alena Prokharchyk < > >> alena.prokharc...@citrix.com<mailto:alena.prokharc...@citrix.com>> > wrote: > >> > >>> 1) Didn't notice "the elephant" - that the Reset Vm option is presented > >> as > >>> a button unlike the icons for other options. UI folks - Brian/Jessica- > >> why > >>> we decided to represent this option differently in the UI? > >>> > >>> 2) Mike, I've looked at the code and the history. We've always > allocated > >> a > >>> new volume during the vm restore call. Hari, can you please confirm > that > >>> this feature you wrote, was designed to work this way > >>> > >>> > >>> -Alena. > >>> > >>> > >>> On 3/19/14, 2:41 PM, "Mike Tutkowski" <mike.tutkow...@solidfire.com > >> <mailto:mike.tutkow...@solidfire.com>> wrote: > >>> > >>>> To clarify: Reboot VM seemed to keep the VM running and just reboot > the > >>>> OS. > >>>> > >>>> Reset VM seemed to shut the VM down and then re-start it (with the > same > >>>> root disk for the OS). > >>>> > >>>> > >>>> On Wed, Mar 19, 2014 at 3:40 PM, Mike Tutkowski < > >>>> mike.tutkow...@solidfire.com<mailto:mike.tutkow...@solidfire.com>> > >> wrote: > >>>> > >>>>> I could be wrong, but I thought as recently as 4.3 that Reset VM > >>>>> essentially stopped and then re-started the VM with the same root > disk. > >>>>> > >>>>> It seemed to differ from Reboot VM only in the sense that the VM was > >>>>> never > >>>>> technically stopped (the OS inside the VM was just rebooted). > >>>>> > >>>>> > >>>>> On Wed, Mar 19, 2014 at 3:38 PM, Mike Tutkowski < > >>>>> mike.tutkow...@solidfire.com<mailto:mike.tutkow...@solidfire.com>> > >> wrote: > >>>>> > >>>>>> I'm using XenServer 6.1 hosts (two of them) in this case. > >>>>>> > >>>>>> > >>>>>> On Wed, Mar 19, 2014 at 3:37 PM, Mike Tutkowski < > >>>>>> mike.tutkow...@solidfire.com<mailto:mike.tutkow...@solidfire.com>> > >> wrote: > >>>>>> > >>>>>>> Yeah, stopping and restarting works fine...as does, I believe, > >>>>>>> rebooting > >>>>>>> the VM. > >>>>>>> > >>>>>>> Right below Reboot VM, there is a Reset VM option. > >>>>>>> > >>>>>>> If that means "re-install," then we probably should clean up the > old > >>>>>>> root disk. > >>>>>>> > >>>>>>> > >>>>>>> On Wed, Mar 19, 2014 at 3:30 PM, Alena Prokharchyk < > >>>>>>> alena.prokharc...@citrix.com<mailto:alena.prokharc...@citrix.com>> > >> wrote: > >>>>>>> > >>>>>>>> don¹t see ³Reset Vm² option in UI; do you mean ³Reboot instance²? > >>>>>>>> I¹ve > >>>>>>>> just tried that, as well as calling stop/startVM from the UI. The > Vm > >>>>>>>> boots > >>>>>>>> up with its original disk. > >>>>>>>> > >>>>>>>> I¹m having Xen/Nfs, not sure it matters > >>>>>>>> > >>>>>>>> -Alena. > >>>>>>>> > >>>>>>>> On 3/19/14, 2:19 PM, "Mike Tutkowski" < > mike.tutkow...@solidfire.com > >> <mailto:mike.tutkow...@solidfire.com>> > >>>>>>>> wrote: > >>>>>>>> > >>>>>>>>> I didn't look into what the GUI calls, but I invoked the Reset VM > >>>>>>>> option > >>>>>>>>> in > >>>>>>>>> the GUI. > >>>>>>>>> > >>>>>>>>> Thanks > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> On Wed, Mar 19, 2014 at 3:17 PM, Alena Prokharchyk < > >>>>>>>>> alena.prokharc...@citrix.com<mailto:alena.prokharc...@citrix.com > >> > >> wrote: > >>>>>>>>> > >>>>>>>>>> Mike, just to confirm - did you call > >>>>>>>>>> stopVirtualMachine/startVirtualMachine apis? > >>>>>>>>>> > >>>>>>>>>> -alena. > >>>>>>>>>> > >>>>>>>>>> On 3/19/14, 1:55 PM, "Mike Tutkowski" > >>>>>>>> <mike.tutkow...@solidfire.com<mailto:mike.tutkow...@solidfire.com > >> > >>>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> Hi, > >>>>>>>>>>> > >>>>>>>>>>> I noticed today while running through some test cases for 4.4 > >>>>>>>> that > >>>>>>>>>>> resetting a VM does not work as expected. > >>>>>>>>>>> > >>>>>>>>>>> Instead of the typical stop and re-start behavior where the VM > is > >>>>>>>>>> booted > >>>>>>>>>>> back up using the same root disk, the VM gets a new root disk > >>>>>>>> when > >>>>>>>> it > >>>>>>>>>> is > >>>>>>>>>>> booted back up. > >>>>>>>>>>> > >>>>>>>>>>> Can anyone confirm this finding for me with his or her setup? > >>>>>>>>>>> > >>>>>>>>>>> Thanks! > >>>>>>>>>>> > >>>>>>>>>>> -- > >>>>>>>>>>> *Mike Tutkowski* > >>>>>>>>>>> *Senior CloudStack Developer, SolidFire Inc.* > >>>>>>>>>>> e: mike.tutkow...@solidfire.com<mailto: > >> mike.tutkow...@solidfire.com> > >>>>>>>>>>> o: 303.746.7302<tel:303.746.7302> > >>>>>>>>>>> Advancing the way the world uses the > >>>>>>>>>>> cloud<http://solidfire.com/solution/overview/?video=play> > >>>>>>>>>>> *(tm)* > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> -- > >>>>>>>>> *Mike Tutkowski* > >>>>>>>>> *Senior CloudStack Developer, SolidFire Inc.* > >>>>>>>>> e: mike.tutkow...@solidfire.com<mailto: > >> mike.tutkow...@solidfire.com> > >>>>>>>>> o: 303.746.7302<tel:303.746.7302> > >>>>>>>>> Advancing the way the world uses the > >>>>>>>>> cloud<http://solidfire.com/solution/overview/?video=play> > >>>>>>>>> *(tm)* > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> -- > >>>>>>> *Mike Tutkowski* > >>>>>>> *Senior CloudStack Developer, SolidFire Inc.* > >>>>>>> e: mike.tutkow...@solidfire.com<mailto: > mike.tutkow...@solidfire.com> > >>>>>>> o: 303.746.7302<tel:303.746.7302> > >>>>>>> Advancing the way the world uses the > >>>>>>> cloud<http://solidfire.com/solution/overview/?video=play> > >>>>>>> *(tm)* > >>>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> *Mike Tutkowski* > >>>>>> *Senior CloudStack Developer, SolidFire Inc.* > >>>>>> e: mike.tutkow...@solidfire.com<mailto:mike.tutkow...@solidfire.com > > > >>>>>> o: 303.746.7302<tel:303.746.7302> > >>>>>> Advancing the way the world uses the > >>>>>> cloud<http://solidfire.com/solution/overview/?video=play> > >>>>>> *(tm)* > >>>>>> > >>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> *Mike Tutkowski* > >>>>> *Senior CloudStack Developer, SolidFire Inc.* > >>>>> e: mike.tutkow...@solidfire.com<mailto:mike.tutkow...@solidfire.com> > >>>>> o: 303.746.7302<tel:303.746.7302> > >>>>> Advancing the way the world uses the > >>>>> cloud<http://solidfire.com/solution/overview/?video=play> > >>>>> *(tm)* > >>>>> > >>>> > >>>> > >>>> > >>>> -- > >>>> *Mike Tutkowski* > >>>> *Senior CloudStack Developer, SolidFire Inc.* > >>>> e: mike.tutkow...@solidfire.com<mailto:mike.tutkow...@solidfire.com> > >>>> o: 303.746.7302<tel:303.746.7302> > >>>> Advancing the way the world uses the > >>>> cloud<http://solidfire.com/solution/overview/?video=play> > >>>> *(tm)* > >>> > >> > >> > >> > >> -- > >> Mike Tutkowski > >> Senior CloudStack Developer, SolidFire Inc. > >> e: mike.tutkow...@solidfire.com<mailto:mike.tutkow...@solidfire.com> > >> o: 303.746.7302<tel:303.746.7302> > >> Advancing the way the world uses the cloud< > >> http://solidfire.com/solution/overview/?video=play>(tm) > >> > >> > >> > >> -- > >> Mike Tutkowski > >> Senior CloudStack Developer, SolidFire Inc. > >> e: mike.tutkow...@solidfire.com<mailto:mike.tutkow...@solidfire.com> > >> o: 303.746.7302 > >> Advancing the way the world uses the cloud< > >> http://solidfire.com/solution/overview/?video=play>(tm) > >> > > > > > > > > -- > > *Mike Tutkowski* > > *Senior CloudStack Developer, SolidFire Inc.* > > e: mike.tutkow...@solidfire.com > > o: 303.746.7302 > > Advancing the way the world uses the > > cloud<http://solidfire.com/solution/overview/?video=play> > > *(tm)* > > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud<http://solidfire.com/solution/overview/?video=play> *(tm)*