> On Feb. 2, 2014, 6:03 p.m., daan Hoogland wrote: > > client/WEB-INF/web.xml, line 63 > > <https://reviews.apache.org/r/12228/diff/2/?file=354637#file354637line63> > > > > can you use tabs instead of spaces (and while you are at it remove > > trailing spaces from this file)? > > Laszlo Hornyak wrote: > trailing white spaces: ok > spaces to tabs: all this file is tabed with spaces, so this would be the > first thing with tabs.
sorry i mean 'spaces instead of tabs'not vice versa. - daan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12228/#review33400 ----------------------------------------------------------- On March 19, 2014, 8:13 p.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12228/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 8:13 p.m.) > > > Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna > Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > CloudStack at first use downloads some 3.5 MB of css and javascript to the > client. With a weak internet connection, this might take a long time. With > gzip compression content can be compressed to 850 KB. > > This version of the patch uses a custom plugin to compress static resources, > so that no dynamic compression is needed at runtime. When the static resource > servlet notices that there is gzipped version of the resource and the client > accepts gzipped content, then it is going to send the gziped version, while > still respects http caching. > > > Diffs > ----- > > client/WEB-INF/web.xml 1af38e1 > client/pom.xml 615d244 > server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION > server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/12228/diff/ > > > Testing > ------- > > yes, tested with firefox and chrome > > > Thanks, > > Laszlo Hornyak > >
