----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19034/#review37257 -----------------------------------------------------------
api/src/com/cloud/network/lb/LoadBalancingRulesService.java <https://reviews.apache.org/r/19034/#comment68673> HoW ABOUT DESCRIBING THE ADDITIONAL PARAMETER IN THE COMMENTS api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBalancerRuleCmd.java <https://reviews.apache.org/r/19034/#comment68674> There is still an additional constraint though that either this or vmidipmap are required. Add comment api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBalancerRuleCmd.java <https://reviews.apache.org/r/19034/#comment68678> Prefer returning empty map instead of null server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/19034/#comment68679> Why not put this code in the LB manager. server/src/com/cloud/network/as/AutoScaleManagerImpl.java <https://reviews.apache.org/r/19034/#comment68677> prefer passing empty maps server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java <https://reviews.apache.org/r/19034/#comment68675> You should have a test written for this condition server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java <https://reviews.apache.org/r/19034/#comment68676> if you had passed in an EMPTY map from the API level you wouldn't have to check for nullness server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java <https://reviews.apache.org/r/19034/#comment68681> where is the test for this? server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java <https://reviews.apache.org/r/19034/#comment68680> where is the test for this? server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java <https://reviews.apache.org/r/19034/#comment68683> test for this? server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java <https://reviews.apache.org/r/19034/#comment68682> grammar in log! - Chiradeep Vittal On March 11, 2014, 12:04 p.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19034/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 12:04 p.m.) > > > Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, Kishan > Kavala, and Murali Reddy. > > > Bugs: CLOUDSTACK-2692 > https://issues.apache.org/jira/browse/CLOUDSTACK-2692 > > > Repository: cloudstack-git > > > Description > ------- > > With this feature load balancing rules assigned/associated to any ip of the > vm nic. The vm nic ip can be primary ip or nic secondary ip. > > > Diffs > ----- > > api/src/com/cloud/network/lb/LoadBalancingRulesService.java 4c87d34 > api/src/org/apache/cloudstack/api/ApiConstants.java 0a3fafd > > api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBalancerRuleCmd.java > 6bd7537 > engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapDao.java 79eaf8e > engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapDaoImpl.java > b0b14fc > engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapVO.java 0a67106 > server/src/com/cloud/network/NetworkServiceImpl.java ebeb31a > server/src/com/cloud/network/as/AutoScaleManagerImpl.java 2fa3821 > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 6f0c1e9 > setup/db/db/schema-430to440.sql ee4cf21 > > Diff: https://reviews.apache.org/r/19034/diff/ > > > Testing > ------- > > Tested configuring the LB rules to vm primary ip and vm secondary ip. > The haproxy config is created correctly for the selected ip. > > > Thanks, > > Jayapal Reddy > >
