Harikrishna, Did you run the findbugs target on your changes? If not could you do that please, if there are any bugs marked a high importance it would cause build failures after we merge it.
Cheers, Hugo On 11 mrt. 2014, at 16:17, Harikrishna Patnala <harikrishna.patn...@citrix.com> wrote: > Hi, > I would like to merge the Virtual Router Service Failure Alerting feature > into 4.4. > > > Feature was proposed on the dev list > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201402.mbox/%3c7de500c0-431b-42ee-bf5c-fbdb20113...@citrix.com%3E > > FS > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Service+Failure+Alerting > > JIRA ticket for the bug > https://issues.apache.org/jira/browse/CLOUDSTACK-6090. > > Integration tests are added in the test script @ > test/integration/smoke/test_VirtualRouter_alerts.py > > Created a review request @ https://reviews.apache.org/r/19038/ > > > Thank you, > Harikrishna
