No problem :) Sorry I didn't run that test case.
On Mon, Mar 10, 2014 at 12:08 PM, Nitin Mehta <nitin.me...@citrix.com>wrote:
> Thanks Mike for the prompt response :).
>
> On 10/03/14 10:44 AM, "Mike Tutkowski" <mike.tutkow...@solidfire.com>
> wrote:
>
> >1d74daf has the fix.
> >
> >Thanks!
> >
> >
> >On Mon, Mar 10, 2014 at 11:42 AM, Mike Tutkowski <
> >mike.tutkow...@solidfire.com> wrote:
> >
> >> OK, I'm sorry about that - I missed a case in testing.
> >>
> >> Line 191 in CloudOrchestrator should be this:
> >>
> >> if (offering.isCustomizedIops() != null && offering.isCustomizedIops())
> >>{
> >>
> >> isCustomizedIops() returns a Boolean - not a boolean.
> >>
> >> I'll check in this fix right now.
> >>
> >>
> >> On Mon, Mar 10, 2014 at 11:32 AM, Mike Tutkowski <
> >> mike.tutkow...@solidfire.com> wrote:
> >>
> >>> Let me see if I can repro it.
> >>>
> >>> One sec
> >>>
> >>>
> >>> On Mon, Mar 10, 2014 at 11:11 AM, Nitin Mehta
> >>><nitin.me...@citrix.com>wrote:
> >>>
> >>>> I am facing the same issue as well.
> >>>>
> >>>> On 10/03/14 10:09 AM, "Koushik Das" <koushik....@citrix.com> wrote:
> >>>>
> >>>> >This is a new install using master. So this is not about db changes
> >>>>but
> >>>> >mostly a bug.
> >>>> >
> >>>> >On 10-Mar-2014, at 9:58 PM, Marcus <shadow...@gmail.com> wrote:
> >>>> >
> >>>> >> Mike has sent out several emails about the DB changes he made.
> >>>> >>
> >>>> >> On Mon, Mar 10, 2014 at 5:28 AM, Koushik Das
> >>>><koushik....@citrix.com>
> >>>> >>wrote:
> >>>> >>> I am seeing the following exception
> >>>> >>>
> >>>> >>> ERROR [c.c.a.ApiServer] (38419149@qtp-1917357200-11:ctx-116b8207
> >>>> >>>ctx-9a54f764) unhandled exception executing api command:
> >>>> >>>[Ljava.lang.String;@36d30b1d
> >>>> >>> java.lang.NullPointerException
> >>>> >>> at
> >>>>
> >>>>
> >>>>>>>org.apache.cloudstack.engine.orchestration.CloudOrchestrator.createV
> >>>>>>>irtu
> >>>> >>>alMachine(CloudOrchestrator.java:191)
> >>>> >>> at
> >>>>
> >>>>
> >>>>>>>com.cloud.vm.UserVmManagerImpl$3.doInTransaction(UserVmManagerImpl.j
> >>>>>>>ava:
> >>>> >>>2908)
> >>>> >>> at
> >>>>
> >>>>
> >>>>>>>com.cloud.vm.UserVmManagerImpl$3.doInTransaction(UserVmManagerImpl.j
> >>>>>>>ava:
> >>>> >>>1)
> >>>> >>> at
> >>>>com.cloud.utils.db.Transaction.execute(Transaction.java:37)
> >>>> >>> at
> >>>>
> >>>>
> >>>>>>>com.cloud.vm.UserVmManagerImpl.commitUserVm(UserVmManagerImpl.java:2
> >>>>>>>821)
> >>>> >>> at
> >>>>
> >>>>
> >>>>>>>com.cloud.vm.UserVmManagerImpl.createVirtualMachine(UserVmManagerImp
> >>>>>>>l.ja
> >>>> >>>va:2759)
> >>>> >>> at
> >>>>
> >>>>
> >>>>>>>com.cloud.vm.UserVmManagerImpl.createAdvancedVirtualMachine(UserVmMa
> >>>>>>>nage
> >>>> >>>rImpl.java:2465)
> >>>> >>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> >>>>Method)
> >>>> >>> at
> >>>>
> >>>>
> >>>>>>>sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl
> >>>>>>>.jav
> >>>> >>>a:57)
> >>>> >>> at
> >>>>
> >>>>
> >>>>>>>sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcce
> >>>>>>>ssor
> >>>> >>>Impl.java:43)
> >>>> >>> at java.lang.reflect.Method.invoke(Method.java:606)
> >>>> >>>
> >>>> >>>
> >>>> >>> git blame shows the following:
> >>>> >>>
> >>>> >>> c427e8db
> >>>>
> >>>>
> >>>>>>>engine/orchestration/src/org/apache/cloudstack/engine/orchestration/
> >>>>>>>Clou
> >>>> >>>dOrchestrator.java (Mike Tutkowski 2014-03-06 14:00:56 -0700
> >>>> 191)
> >>>> >>> if (offering.isCustomizedIops()) {
> >>>> >>>
> >>>> >>> And in the disk_offering table in the db the values for this
> >>>>property
> >>>> >>>is set to null for all entries.
> >>>> >>>
> >>>> >>> What is the correct way to use this property? Should the code be
> >>>> fixed
> >>>> >>>or the db entries need to be correctly updated?
> >>>> >>>
> >>>> >>> -Koushik
> >>>> >>>
> >>>> >
> >>>>
> >>>>
> >>>
> >>>
> >>> --
> >>> *Mike Tutkowski*
> >>> *Senior CloudStack Developer, SolidFire Inc.*
> >>> e: mike.tutkow...@solidfire.com
> >>> o: 303.746.7302
> >>> Advancing the way the world uses the
> >>>cloud<http://solidfire.com/solution/overview/?video=play>
> >>> *(tm)*
> >>>
> >>
> >>
> >>
> >> --
> >> *Mike Tutkowski*
> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> e: mike.tutkow...@solidfire.com
> >> o: 303.746.7302
> >> Advancing the way the world uses the
> >>cloud<http://solidfire.com/solution/overview/?video=play>
> >> *(tm)*
> >>
> >
> >
> >
> >--
> >*Mike Tutkowski*
> >*Senior CloudStack Developer, SolidFire Inc.*
> >e: mike.tutkow...@solidfire.com
> >o: 303.746.7302
> >Advancing the way the world uses the
> >cloud<http://solidfire.com/solution/overview/?video=play>
> >*(tm)*
>
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*(tm)*
