I did look at it, but haven't had a chance to try to repo. I should be able to try to repo it today.
Thanks! On Sun, Mar 9, 2014 at 10:05 PM, Mandar Barve <mandar.ba...@sungard.com>wrote: > Hi Mike, > Did you get a chance to look at this? > > Thanks, > Mandar > > > On Wed, Mar 5, 2014 at 10:12 AM, Mandar Barve <mandar.ba...@sungard.com>wrote: > >> I tested this with CS 4.3. >> >> Thanks, >> Mandar >> >> >> On Tue, Mar 4, 2014 at 9:09 PM, Mike Tutkowski < >> mike.tutkow...@solidfire.com> wrote: >> >>> Hi, >>> >>> Can you tell me what release you tested this with? I noticed the problem >>> while developing on CloudStack 4.3. >>> >>> Thanks! >>> >>> >>> On Tue, Mar 4, 2014 at 3:43 AM, Mandar Barve >>> <mandar.ba...@sungard.com>wrote: >>> >>>> Hi, >>>> I tried to reproduce the issue but couldn't get this to fail >>>> for insufficient space. I then injected an exception trying to list files >>>> from a non existent path (added this code in the "try" block). This landed >>>> me into the exception handling code. It raised correct exception saying >>>> "file not found" which was captured in the management server vmops log >>>> file. It was not displayed by the GUI. GUI just reported Error (Are we >>>> looking for GUI displaying error code?). The plugin code returns "0" >>>> immediately after the line of code that raises exception but I think this >>>> applies only for successful execution of the plugin code that reverts the >>>> snapshot. >>>> >>>> If any exception is raised (e.g. in the reported case here >>>> insufficient space) then the code should return appropriate error message >>>> to the caller as I found. In exception handling path return "0" wouldn't >>>> execute. >>>> >>>> I don't see any problem here. Let me know if I am missing anything. >>>> >>>> Thanks, >>>> Mandar >>>> >>> >>> >>> >>> -- >>> *Mike Tutkowski* >>> *Senior CloudStack Developer, SolidFire Inc.* >>> e: mike.tutkow...@solidfire.com >>> o: 303.746.7302 >>> Advancing the way the world uses the >>> cloud<http://solidfire.com/solution/overview/?video=play> >>> *(tm)* >>> >> >> > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud<http://solidfire.com/solution/overview/?video=play> *(tm)*
