----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/#review36212 -----------------------------------------------------------
Amogh - thanks for the patch. Some small issues on this patch. I've got larger comments but I'll post them on the "Realhostip.com shutting down on June 30" thread. core/src/com/cloud/info/ConsoleProxyInfo.java <https://reviews.apache.org/r/18759/#comment67147> Can you clean up trailing whitespace added in lines like this? server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java <https://reviews.apache.org/r/18759/#comment67148> This doesn't seem relevant to the issue at hand. systemvm/conf/consoleproxy.properties <https://reviews.apache.org/r/18759/#comment67149> Why change the listening port? I don't see what this has to do with moving from HTTPS to HTTP... - John Kinsella On March 5, 2014, 1:42 a.m., Amogh Vasekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18759/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 1:42 a.m.) > > > Review request for cloudstack, Demetrius Tsitrelis and John Kinsella. > > > Repository: cloudstack-git > > > Description > ------- > > Changes to support HTTP mode in Console Proxy, per > http://www.mail-archive.com/dev@cloudstack.apache.org/msg24151.html , as > realhostip may go away > > More details here : > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Realhost+IP+changes > > > Diffs > ----- > > core/src/com/cloud/info/ConsoleProxyInfo.java 3439f3d > > engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java > a649bb7 > > plugins/storage/image/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackImageStoreDriverImpl.java > 52cad3b > server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 3572127 > server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java > a3f837b > systemvm/conf/consoleproxy.properties bb452f5 > > Diff: https://reviews.apache.org/r/18759/diff/ > > > Testing > ------- > > Tested on local environment by > 1. Using HTTP based console proxy > 2. HTTPS with realhostip domain > 3. HTTPS with custom domain and self-signed cert > 4. Secondary storage template download with custom domain and self-signed cert > > > Thanks, > > Amogh Vasekar > >
