----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18673/#review36162 -----------------------------------------------------------
Ship it! Ship It! - Brian Angus On March 3, 2014, 12:09 a.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18673/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 12:09 a.m.) > > > Review request for cloudstack, Brian Angus and Mike Tutkowski. > > > Bugs: cloudstack-6192 > https://issues.apache.org/jira/browse/cloudstack-6192 > > > Repository: cloudstack-git > > > Description > ------- > > I've noticed that during migrations or vm deployments, if connectPhysicalDisk > fails, the system continues with trying to do the start and/or migration. > This would cancel vm start if the storage adaptor tells us that the pre-work > of connecting the disks has failed. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > e6c750b > > Diff: https://reviews.apache.org/r/18673/diff/ > > > Testing > ------- > > Still running > > > Thanks, > > Marcus Sorensen > >
